From: Ilya Tocar <tocarip.intel@gmail.com>
To: Kirill Yukhin <kirill.yukhin@gmail.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>,
Uros Bizjak <ubizjak@gmail.com>, "H.J. Lu" <hjl.tools@gmail.com>
Subject: [PATCH, PR65915] Fix float conversion split.
Date: Tue, 28 Apr 2015 16:22:00 -0000 [thread overview]
Message-ID: <20150428162049.GA62528@msticlxl7.ims.intel.com> (raw)
In-Reply-To: <20150324134311.GA40649@msticlxl57.ims.intel.com>
> > I've renamed EXT_SSE_REG_P into EXT_REX_SSE_REG_P for consistency.
> > Ok for stage1?
> Patch is OK for stage1.
>
> --
> Thanks, K
>
>
> > On 19 Mar 12:24, Ilya Tocar wrote:
> > > Hi,
> > >
> > > There were some discussion about "x" constraints being too conservative
> > > for some patterns in i386.md.
> > > Patch below fixes it. This is probably stage1 material.
> > >
> > > ChangeLog:
> > >
> > > gcc/
> > >
> > 2015-03-23 Ilya Tocar <ilya.tocar@intel.com>
> >
> > * config/i386/i386.h (EXT_REX_SSE_REG_P): New.
> > * config/i386/i386.md (*cmpi<FPCMP:unord><MODEF:mode>_mixed): Use "v"
> > constraint.
> > (*cmpi<FPCMP:unord><MODEF:mode>_sse): Ditto.
> > (*movxi_internal_avx512f): Ditto.
> > (define_split): Check for xmm16+, when splitting scalar float_extend.
> > (*extendsfdf2_mixed): Use "v" constraint.
> > (*extendsfdf2_sse): Ditto.
> > (define_split): Check for xmm16+, when splitting scalar float_truncate.
> > (*truncdfsf_fast_sse): Use "v" constraint.
> > (fix_trunc<MODEF:mode><SWI48:mode>_sse): Ditto.
> > (*float<SWI48:mode><MODEF:mode>2_sse): Ditto.
> > (define_peephole2): Check for xmm16+, when converting scalar
> > float_truncate.
> > (define_peephole2): Check for xmm16+, when converting scalar
> > float_extend.
> > (*fop_<mode>_comm_mixed): Use "v" constraint.
> > (*fop_<mode>_comm_sse): Ditto.
> > (*fop_<mode>_1_mixed): Ditto.
> > (*sqrt<mode>2_sse): Ditto.
> > (*ieee_s<ieee_maxmin><mode>3): Ditto.
> >
> >
Hi,
Looks like I missed some splits, which caused PR65915.
Patch below fixes it.
Ok for trunk?
2015-04-28 Ilya Tocar <ilya.tocar@intel.com>
* config/i386/i386.md (define_split): Check for xmm16+,
when splitting scalar float conversion.
---
gcc/config/i386/i386.md | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/gcc/config/i386/i386.md b/gcc/config/i386/i386.md
index 937871a..af1cd9b 100644
--- a/gcc/config/i386/i386.md
+++ b/gcc/config/i386/i386.md
@@ -4897,7 +4897,9 @@
"TARGET_SSE2 && TARGET_SSE_MATH
&& TARGET_USE_VECTOR_CONVERTS && optimize_function_for_speed_p (cfun)
&& reload_completed && SSE_REG_P (operands[0])
- && (MEM_P (operands[1]) || TARGET_INTER_UNIT_MOVES_TO_VEC)"
+ && (MEM_P (operands[1]) || TARGET_INTER_UNIT_MOVES_TO_VEC)
+ && (!EXT_REX_SSE_REG_P (operands[0])
+ || TARGET_AVX512VL)"
[(const_int 0)]
{
operands[3] = simplify_gen_subreg (<ssevecmode>mode, operands[0],
@@ -4921,7 +4923,9 @@
"TARGET_SSE2 && TARGET_SSE_MATH
&& TARGET_SSE_PARTIAL_REG_DEPENDENCY
&& optimize_function_for_speed_p (cfun)
- && reload_completed && SSE_REG_P (operands[0])"
+ && reload_completed && SSE_REG_P (operands[0])
+ && (!EXT_REX_SSE_REG_P (operands[0])
+ || TARGET_AVX512VL)"
[(const_int 0)]
{
const machine_mode vmode = <MODEF:ssevecmode>mode;
--
1.8.3.1
next prev parent reply other threads:[~2015-04-28 16:21 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-19 9:24 [PATCH] Make wider use of "v" constraint in i386.md Ilya Tocar
[not found] ` <20150323160222.GB10265@msticlxl7.ims.intel.com>
2015-03-24 13:43 ` Kirill Yukhin
2015-04-28 16:22 ` Ilya Tocar [this message]
2015-04-28 16:59 ` [PATCH, PR65915] Fix float conversion split H.J. Lu
2015-04-30 15:18 ` Ilya Tocar
2015-04-30 15:22 ` H.J. Lu
2015-05-04 8:08 ` Uros Bizjak
2015-05-05 13:03 ` Ilya Tocar
2015-05-05 13:13 ` Uros Bizjak
2015-04-17 8:10 ` [PATCH] Make wider use of "v" constraint in i386.md Uros Bizjak
2015-04-27 15:28 ` Ilya Tocar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150428162049.GA62528@msticlxl7.ims.intel.com \
--to=tocarip.intel@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=hjl.tools@gmail.com \
--cc=kirill.yukhin@gmail.com \
--cc=ubizjak@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).