From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-patches-return-396374-listarch-gcc-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 117047 invoked by alias); 29 Apr 2015 18:14:23 -0000
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-patches.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
Received: (qmail 116903 invoked by uid 89); 29 Apr 2015 18:14:22 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2
X-Spam-User: qpsmtpd, 2 recipients
X-HELO: mx1.redhat.com
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 29 Apr 2015 18:14:21 +0000
Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t3TIEJLb021807	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL);	Wed, 29 Apr 2015 14:14:20 -0400
Received: from localhost (ovpn-116-62.ams2.redhat.com [10.36.116.62])	by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t3TIEJo3031912;	Wed, 29 Apr 2015 14:14:19 -0400
Date: Wed, 29 Apr 2015 18:51:00 -0000
From: Jonathan Wakely <jwakely@redhat.com>
To: Doug Evans <dje@google.com>
Cc: gcc-patches <gcc-patches@gcc.gnu.org>, libstdc++ <libstdc++@gcc.gnu.org>,        Siva Reddy <sivachandra@google.com>
Subject: Re: [PATCH] [libstdc++/65839] whatis support for xmethods
Message-ID: <20150429181418.GP3618@redhat.com>
References: <yjt2d22pur6l.fsf@ruffy.mtv.corp.google.com> <20150428121618.GV3618@redhat.com> <CADPb22QPe2t4UX1hK5Ob95ZXruHTsth-dMzT_Hx2ceojyEqK8w@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Disposition: inline
In-Reply-To: <CADPb22QPe2t4UX1hK5Ob95ZXruHTsth-dMzT_Hx2ceojyEqK8w@mail.gmail.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
X-SW-Source: 2015-04/txt/msg01914.txt.bz2

On 29/04/15 10:57 -0700, Doug Evans wrote:
>On Tue, Apr 28, 2015 at 5:16 AM, Jonathan Wakely <jwakely@redhat.com> wrote:
>> On 27/04/15 15:44 -0700, Doug Evans wrote:
>>>
>>>         PR libstdc++/65839
>>>         * python/libstdcxx/v6/xmethods.py (get_bool_type): New function.
>>>         Replace all lookups of "bool" with this.
>>>         (get_std_size_type): New function.  Replace all lookups of
>>> std::size_t
>>>         with this.
>>>         (ArrayWorkerBase): Rename arg valtype to elem_type for
>>> consistency,
>>
>>
>> I'd say ArrayWorkerBase's _valtype is correct and deque and vector are
>> wrong to use _elemtype.
>>
>> C++ containers use value_type for the type of the container objects.
>> Smart pointers use element_type for the type of the owned object. So
>> using _valtype for containers and _elemtype for unique_ptr would be
>> consistent with the C++ library types.
>
>Hi.
>Here's v2.
>It's assumes the naming cleanup patch has been applied.
>https://gcc.gnu.org/ml/libstdc++/2015-04/msg00183.html
>
>Regression tested on amd64-linux.

Looks good, OK for trunk, thanks.

If you want to fix this on the branch too then the renaming patch and
this one are both OK for the gcc-5-branch as well.