From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 103189 invoked by alias); 30 Apr 2015 12:13:42 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 103134 invoked by uid 89); 30 Apr 2015 12:13:42 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 30 Apr 2015 12:13:41 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (Postfix) with ESMTPS id E04058EFD6; Thu, 30 Apr 2015 12:13:39 +0000 (UTC) Received: from tucnak.zalov.cz (ovpn-116-89.ams2.redhat.com [10.36.116.89]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t3UCDcFM005145 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Thu, 30 Apr 2015 08:13:39 -0400 Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.14.9/8.14.9) with ESMTP id t3UCDaQG002290; Thu, 30 Apr 2015 14:13:36 +0200 Received: (from jakub@localhost) by tucnak.zalov.cz (8.14.9/8.14.9/Submit) id t3UCDXfw002289; Thu, 30 Apr 2015 14:13:33 +0200 Date: Thu, 30 Apr 2015 12:17:00 -0000 From: Jakub Jelinek To: Trevor Saunders Cc: Andreas Schwab , Jeff Law , tbsaunde+gcc@tbsaunde.org, gcc-patches@gcc.gnu.org Subject: Re: [PATCH 3/8] add default for PCC_BITFIELD_TYPE_MATTERS Message-ID: <20150430121333.GP1751@tucnak.redhat.com> Reply-To: Jakub Jelinek References: <87oam7nmck.fsf@igel.home> <20150429212811.GA17482@tsaunders-iceball.corp.tor1.mozilla.com> <87383iob0i.fsf@igel.home> <5541548F.40608@redhat.com> <20150429222548.GB17482@tsaunders-iceball.corp.tor1.mozilla.com> <55415B46.5020801@redhat.com> <20150430001316.GC17482@tsaunders-iceball.corp.tor1.mozilla.com> <20150430021055.GD17482@tsaunders-iceball.corp.tor1.mozilla.com> <87mw1qhzsi.fsf@igel.home> <20150430115718.GA1508@tsaunders-iceball.corp.tor1.mozilla.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150430115718.GA1508@tsaunders-iceball.corp.tor1.mozilla.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-IsSubscribed: yes X-SW-Source: 2015-04/txt/msg02024.txt.bz2 On Thu, Apr 30, 2015 at 07:58:33AM -0400, Trevor Saunders wrote: > On Thu, Apr 30, 2015 at 08:54:05AM +0200, Andreas Schwab wrote: > > Trevor Saunders writes: > > > > >> diff --git a/libobjc/encoding.c b/libobjc/encoding.c > > >> index 7333908..20ace46 100644 > > >> --- a/libobjc/encoding.c > > >> +++ b/libobjc/encoding.c > > >> @@ -1167,7 +1167,7 @@ objc_layout_structure_next_member (struct objc_struct_layout *layout) > > >> /* Record must have at least as much alignment as any field. > > >> Otherwise, the alignment of the field within the record > > >> is meaningless. */ > > >> -#ifndef PCC_BITFIELD_TYPE_MATTERS > > >> +#if !PCC_BITFIELD_TYPE_MATTERS > > > > With `#define PCC_BITFIELD_TYPE_MATTERS true' this expands to `#if > > !true' which evaluates to 1 since true isn't a defined identifier? > > I think true is a defined identifier since this is compiled as c11. true is not a defined identifier, neither in C89, nor in C99, nor in C11. In C, true may be a macro if stdbool.h is included. system.h has: #undef TRUE #undef FALSE #ifdef __cplusplus /* Obsolete. */ # define TRUE true # define FALSE false #else /* !__cplusplus */ # undef bool # undef true # undef false # define bool unsigned char # define true 1 # define false 0 /* Obsolete. */ # define TRUE true # define FALSE false #endif /* !__cplusplus */ if it is included. Jakub