From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15896 invoked by alias); 30 Apr 2015 12:25:30 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 15887 invoked by uid 89); 30 Apr 2015 12:25:29 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.2 required=5.0 tests=AWL,BAYES_05,KAM_LAZY_DOMAIN_SECURITY,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 X-HELO: paperclip.tbsaunde.org Received: from tbsaunde.org (HELO paperclip.tbsaunde.org) (66.228.47.254) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 30 Apr 2015 12:25:29 +0000 Received: from tsaunders-iceball.corp.tor1.mozilla.com (unknown [23.233.68.71]) by paperclip.tbsaunde.org (Postfix) with ESMTPSA id 9E34DC0AA; Thu, 30 Apr 2015 12:25:24 +0000 (UTC) Date: Thu, 30 Apr 2015 12:34:00 -0000 From: Trevor Saunders To: Andreas Schwab Cc: Jeff Law , tbsaunde+gcc@tbsaunde.org, gcc-patches@gcc.gnu.org Subject: Re: [PATCH 3/8] add default for PCC_BITFIELD_TYPE_MATTERS Message-ID: <20150430122513.GB1508@tsaunders-iceball.corp.tor1.mozilla.com> References: <1430114140-15817-1-git-send-email-tbsaunde+gcc@tbsaunde.org> <1430114140-15817-4-git-send-email-tbsaunde+gcc@tbsaunde.org> <87oam7nmck.fsf@igel.home> <20150429212811.GA17482@tsaunders-iceball.corp.tor1.mozilla.com> <87383iob0i.fsf@igel.home> <5541548F.40608@redhat.com> <20150429222548.GB17482@tsaunders-iceball.corp.tor1.mozilla.com> <87r3r2i0el.fsf@igel.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87r3r2i0el.fsf@igel.home> User-Agent: Mutt/1.5.23 (2014-03-12) X-SW-Source: 2015-04/txt/msg02029.txt.bz2 On Thu, Apr 30, 2015 at 08:40:50AM +0200, Andreas Schwab wrote: > Trevor Saunders writes: > > > actually pointing out libojc/encoding.c was more useful since that makes > > it pretty clear the ifndef PCC_BITFIELD_TYPE_MATTERS there just needs to > > be changed to #if ! > > That probably won't work on arm or powerpc or vax: > > gcc/config/arm/arm.h:#define PCC_BITFIELD_TYPE_MATTERS TARGET_AAPCS_BASED > gcc/config/rs6000/sysv4.h:#define PCC_BITFIELD_TYPE_MATTERS (TARGET_BITFIELD_TYPE) > gcc/config/vax/vax.h:#define PCC_BITFIELD_TYPE_MATTERS (! TARGET_VAXC_ALIGNMENT) hrmph, I don't see how this code ever worked correctly on those targets. Consider the arm case the value of PCC_BITFIELD_TYPE_MATTERS depends on arm_abi so if the bitfield type matters depends on what abi libobjc is being built for, but its not obvious how libobjc is dealing with that. I suppose it could be that libobjc is using this macro to know something else that only sort of relaed somehow. Unfortunately this code seems to come from the creation of libobjc/ in 11998 and though the commit says it is a move from gcc/objc/ nothing appears to have been removed from gcc/objc/. I guess the "best" thing to do is justadd a __PCC_BITFIELD_TYPE_MATTERS__ that gcc defines and use that in libobjc? Trev > > Andreas. > > -- > Andreas Schwab, schwab@linux-m68k.org > GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 > "And now for something completely different."