From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26615 invoked by alias); 1 May 2015 15:11:27 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 26595 invoked by uid 89); 1 May 2015 15:11:26 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-Spam-User: qpsmtpd, 2 recipients X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 01 May 2015 15:11:25 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t41FBKGY016822 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 1 May 2015 11:11:20 -0400 Received: from localhost (ovpn-116-62.ams2.redhat.com [10.36.116.62]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t41FBIb2021829; Fri, 1 May 2015 11:11:19 -0400 Date: Fri, 01 May 2015 15:11:00 -0000 From: Jonathan Wakely To: Rainer Orth Cc: libstdc++@gcc.gnu.org, gcc-patches@gcc.gnu.org Subject: Re: [patch] Implement ISO/IEC TS 18822 C++ File system TS Message-ID: <20150501151117.GC3618@redhat.com> References: <20150430173236.GT3618@redhat.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="OxDG9cJJSSQMUzGF" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) X-SW-Source: 2015-05/txt/msg00059.txt.bz2 --OxDG9cJJSSQMUzGF Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline Content-length: 1154 On 01/05/15 14:45 +0200, Rainer Orth wrote: >Jonathan Wakely writes: > >> I've tested this on GNU/Linux and DragonFly BSD, but as it's probably >> not going to build everywhere I've added the configure option >> --enable-libstdcxx-filesystem-ts which defaults to enabled on GNU, BSD >> and Solaris targets, and disabled elsewhere for now. If it fails to >> build on any of those targets we can change the default while we fix >> the problem. > >Unfortunately, the patch breaks Solaris 10 bootstrap, which lacks >fchmodat: > >/vol/gcc/src/hg/trunk/local/libstdc++-v3/src/filesystem/ops.cc: In function 'void std::experimental::filesystem::v1::permissions(const std::experimental::filesystem::v1::__cxx11::path&, std::experimental::filesystem::v1::perms, std::error_code&)': >/vol/gcc/src/hg/trunk/local/libstdc++-v3/src/filesystem/ops.cc:890:17: error: '::fchmodat' has not been declared > if (int err = ::fchmodat(AT_FDCWD, p.c_str(), static_cast(prms), 0)) > ^ >make[6]: *** [ops.lo] Error 1 Sorry about that, I'll add a check for fchmodat, in the meantime this will fix bootstrap. Committed as obvious. --OxDG9cJJSSQMUzGF Content-Type: text/x-patch; charset=us-ascii Content-Disposition: attachment; filename="patch.txt" Content-length: 1157 commit f4768ebcfd68e2fa6e4763d0b681e8fe710c64c4 Author: Jonathan Wakely Date: Fri May 1 16:09:28 2015 +0100 * acinclude.m4 (GLIBCXX_ENABLE_FILESYSTEM_TS): Disable for solaris. * configure: Regenerate. diff --git a/libstdc++-v3/acinclude.m4 b/libstdc++-v3/acinclude.m4 index 537ca6f..9d8d96d 100644 --- a/libstdc++-v3/acinclude.m4 +++ b/libstdc++-v3/acinclude.m4 @@ -3923,7 +3923,7 @@ AC_DEFUN([GLIBCXX_ENABLE_FILESYSTEM_TS], [ enable_libstdcxx_filesystem_ts=yes ;; solaris*) - enable_libstdcxx_filesystem_ts=yes + enable_libstdcxx_filesystem_ts=no ;; *) enable_libstdcxx_filesystem_ts=no diff --git a/libstdc++-v3/configure b/libstdc++-v3/configure index 0a059c6..5ecfdeb 100755 --- a/libstdc++-v3/configure +++ b/libstdc++-v3/configure @@ -79163,7 +79163,7 @@ $as_echo_n "checking whether to build Filesystem TS support... " >&6; } enable_libstdcxx_filesystem_ts=yes ;; solaris*) - enable_libstdcxx_filesystem_ts=yes + enable_libstdcxx_filesystem_ts=no ;; *) enable_libstdcxx_filesystem_ts=no --OxDG9cJJSSQMUzGF--