From: Alan Modra <amodra@gmail.com>
To: David Edelsohn <dje.gcc@gmail.com>
Cc: Eric Botcazou <ebotcazou@adacore.com>,
Andrew Pinski <pinskia@gmail.com>,
GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [rs6000] Fix compare debug failure on AIX
Date: Sat, 02 May 2015 04:24:00 -0000 [thread overview]
Message-ID: <20150502042417.GC4302@bubble.grove.modra.org> (raw)
In-Reply-To: <CAGWvnynkc8eLtPndHRffZ-VfwgYyMD1m7m5Y37+Y84+KKP31rg@mail.gmail.com>
On Fri, May 01, 2015 at 09:48:51AM -0400, David Edelsohn wrote:
> On Thu, Apr 30, 2015 at 7:28 AM, Eric Botcazou <ebotcazou@adacore.com> wrote:
> >> We might want to check if doing -Og and not just -O0.
> >
> > You're right, thanks, amended patch attached, same ChangeLog.
>
> Why should GCC unnecessarily create stack frames to avoid
> compare-debug testcase failures?
More to the point, do you need a frame on AIX when debugging? If yes
then the correct change is to replace
else if (TARGET_XCOFF && write_symbols != NO_DEBUG)
info_ptr->push_p = 1;
with
else if (TARGET_XCOFF)
info_ptr->push_p = 1;
If no, then the correct change is to delete those lines from
rs6000_stack_info, and fix the comment.
https://gcc.gnu.org/ml/gcc-patches/2003-03/msg01693.html
--
Alan Modra
Australia Development Lab, IBM
next prev parent reply other threads:[~2015-05-02 4:24 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-29 10:31 Eric Botcazou
2015-04-29 10:37 ` pinskia
2015-04-30 11:35 ` Eric Botcazou
2015-05-01 13:48 ` David Edelsohn
2015-05-02 4:24 ` Alan Modra [this message]
2015-05-02 10:05 ` Eric Botcazou
2015-05-04 0:32 ` David Edelsohn
2015-05-04 8:33 ` Richard Biener
2015-05-04 13:26 ` Tristan Gingold
2015-05-11 8:25 ` Eric Botcazou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150502042417.GC4302@bubble.grove.modra.org \
--to=amodra@gmail.com \
--cc=dje.gcc@gmail.com \
--cc=ebotcazou@adacore.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=pinskia@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).