From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 101180 invoked by alias); 2 May 2015 04:24:27 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 101169 invoked by uid 89); 2 May 2015 04:24:26 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-pa0-f53.google.com Received: from mail-pa0-f53.google.com (HELO mail-pa0-f53.google.com) (209.85.220.53) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Sat, 02 May 2015 04:24:25 +0000 Received: by pabtp1 with SMTP id tp1so108574759pab.2 for ; Fri, 01 May 2015 21:24:23 -0700 (PDT) X-Received: by 10.67.3.195 with SMTP id by3mr23440653pad.109.1430540663718; Fri, 01 May 2015 21:24:23 -0700 (PDT) Received: from bubble.grove.modra.org ([58.160.155.134]) by mx.google.com with ESMTPSA id xs10sm6271696pab.35.2015.05.01.21.24.22 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 01 May 2015 21:24:22 -0700 (PDT) Received: by bubble.grove.modra.org (Postfix, from userid 1000) id 3D6DEEA0072; Sat, 2 May 2015 13:54:17 +0930 (ACST) Date: Sat, 02 May 2015 04:24:00 -0000 From: Alan Modra To: David Edelsohn Cc: Eric Botcazou , Andrew Pinski , GCC Patches Subject: Re: [rs6000] Fix compare debug failure on AIX Message-ID: <20150502042417.GC4302@bubble.grove.modra.org> Mail-Followup-To: David Edelsohn , Eric Botcazou , Andrew Pinski , GCC Patches References: <1633828.L6eKc0dpVU@polaris> <1752984.z0ljzjyPbr@polaris> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) X-IsSubscribed: yes X-SW-Source: 2015-05/txt/msg00119.txt.bz2 On Fri, May 01, 2015 at 09:48:51AM -0400, David Edelsohn wrote: > On Thu, Apr 30, 2015 at 7:28 AM, Eric Botcazou wrote: > >> We might want to check if doing -Og and not just -O0. > > > > You're right, thanks, amended patch attached, same ChangeLog. > > Why should GCC unnecessarily create stack frames to avoid > compare-debug testcase failures? More to the point, do you need a frame on AIX when debugging? If yes then the correct change is to replace else if (TARGET_XCOFF && write_symbols != NO_DEBUG) info_ptr->push_p = 1; with else if (TARGET_XCOFF) info_ptr->push_p = 1; If no, then the correct change is to delete those lines from rs6000_stack_info, and fix the comment. https://gcc.gnu.org/ml/gcc-patches/2003-03/msg01693.html -- Alan Modra Australia Development Lab, IBM