public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jonathan Wakely <jwakely@redhat.com>
To: Ed Smith-Rowland <3dw4rd@verizon.net>
Cc: Ville Voutilainen <ville.voutilainen@gmail.com>,
	       "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>,
	       libstdc++@gcc.gnu.org
Subject: Re: [libstdc++ PATCH] Implement observer_ptr
Date: Sat, 02 May 2015 13:01:00 -0000	[thread overview]
Message-ID: <20150502130150.GX3618@redhat.com> (raw)
In-Reply-To: <5544C7F5.2080305@verizon.net>

On 02/05/15 08:49 -0400, Ed Smith-Rowland wrote:
>OK.  Thanks.
>
>I do remember an SD-6 discussion about how annoying the 
>define-the-macro-in-all-relevant-headers was.
>I didn't know there was a resolution.  I need to reeducate myself.
>Meanwhile I'll rollback my patch.
>
>Reverted in 222722.
>
>I'll ask next time.
>Sorry for the noise.

OK, no problem. I wasn't going to ask you to revert it, as it didn't
really do any harm, I just don't think it is required to be in every
header.

I've been wondering if it would be better to just put all the
feature-test macros in a central place, like <bits/c++config.h> (and
maybe somewhre separate for the "experimental" ones). Stephen Kelly's
complaints about Boost having to include loads of large std::lib
headers to test the macros is a valid complaint about the current SD-6
scheme.

I *think* that would also still be conforming, because the macro would
be defined when you include the right header ... it would just be
defined when you include any other headers too :-)

      reply	other threads:[~2015-05-02 13:01 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-01 13:37 Ville Voutilainen
2015-05-01 21:01 ` Jonathan Wakely
2015-05-01 21:26   ` Jonathan Wakely
2015-05-02  2:02   ` Ed Smith-Rowland
2015-05-02  9:40     ` Jonathan Wakely
2015-05-02  9:42       ` Jonathan Wakely
2015-05-02 12:50         ` Ed Smith-Rowland
2015-05-02 13:01           ` Jonathan Wakely [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150502130150.GX3618@redhat.com \
    --to=jwakely@redhat.com \
    --cc=3dw4rd@verizon.net \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=libstdc++@gcc.gnu.org \
    --cc=ville.voutilainen@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).