From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 126285 invoked by alias); 4 May 2015 09:21:18 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 126275 invoked by uid 89); 4 May 2015 09:21:18 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Mon, 04 May 2015 09:21:17 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t449LCAI018654 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 4 May 2015 05:21:12 -0400 Received: from tucnak.zalov.cz (ovpn-116-89.ams2.redhat.com [10.36.116.89]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t449LA7r028729 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Mon, 4 May 2015 05:21:12 -0400 Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.14.9/8.14.9) with ESMTP id t449L96q015641; Mon, 4 May 2015 11:21:09 +0200 Received: (from jakub@localhost) by tucnak.zalov.cz (8.14.9/8.14.9/Submit) id t449L6gs015640; Mon, 4 May 2015 11:21:06 +0200 Date: Mon, 04 May 2015 09:21:00 -0000 From: Jakub Jelinek To: Rainer Orth , Richard Biener Cc: "H.J. Lu" , gcc-patches@gcc.gnu.org Subject: Re: [committed, gcc-5-branch] Set DEV-PHASE to prerelease Message-ID: <20150504092106.GB1751@tucnak.redhat.com> Reply-To: Jakub Jelinek References: <20150423233152.GA9034@intel.com> <20150424060006.GI1751@tucnak.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) X-IsSubscribed: yes X-SW-Source: 2015-05/txt/msg00199.txt.bz2 On Mon, May 04, 2015 at 11:13:51AM +0200, Rainer Orth wrote: > Jakub Jelinek writes: > > > On Thu, Apr 23, 2015 at 04:31:52PM -0700, H.J. Lu wrote: > >> Hi, > >> > >> I checked this patch into gcc-5-branch. > > > > That's wrong according to https://gcc.gnu.org/develop.html#num_scheme > > HJ has a point, though: with DEV-PHASE remaining empty, all post-5.1.0 > versions of gcc identify as 5.1.1, with no way of telling them apart, > like datestamp and revison. That suggests we should change DATESTAMP_s := "\"$(if $(DEVPHASE_c), $(DATESTAMP_c))\"" so that it would expand to DATESTAMP_c also if DEVPHASE_c is empty, but BASEVER_c does not end with .0 Jakub