public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jan Hubicka <hubicka@ucw.cz>
To: Eric Botcazou <ebotcazou@adacore.com>
Cc: Rainer Orth <ro@cebitec.uni-bielefeld.de>,
	gcc-patches@gcc.gnu.org,	Jan Hubicka <hubicka@ucw.cz>
Subject: Re: Extend verify_type to check various uses of TYPE_MINVAL
Date: Mon, 04 May 2015 23:50:00 -0000	[thread overview]
Message-ID: <20150504235012.GA7408@kam.mff.cuni.cz> (raw)
In-Reply-To: <1865073.9fsSZs5qMy@polaris>

> > Not obvious enough, it seems: this patch broke gnat.dg/lto* tests at
> > least on i386-pc-solaris2.10.  E.g.
> > 
> > FAIL: gnat.dg/lto1.adb (test for excess errors)
> > WARNING: gnat.dg/lto1.adb compilation failed to produce executable
> > 
> > FAIL: gnat.dg/lto1.adb (test for excess errors)
> > Excess errors:
> > /vol/gcc/src/hg/trunk/solaris/gcc/testsuite/gnat.dg/lto1_pkg.adb:23:1:
> > error: TYPE_MIN_VALUE is not constant 
> 
> TYPE_MIN_VALUE can be arbitrary in Ada, with or without LTO.  For
> 
> package Q is
> 
>    function LB return Natural;
>    function UB return Natural;
> 
> end Q;
> with Q;
> 
> package P is
> 
>    type Arr1 is array (Natural range <>) of Boolean;
> 
>    subtype Arr2 is Arr1 (Q.LB .. Q.UB);
> 
> end P;
> 
> the TYPE_DOMAIN of Arr2 is
> 
>     domain <integer_type 0x7ffff69be000 type <integer_type 0x7ffff6d0e0a8 
> sizetype>
>         sizes-gimplified visited DI size <integer_cst 0x7ffff6d0abb8 64> unit 
> size <integer_cst 0x7ffff6d0abd0 8>
>         align 64 symtab 0 alias set -1 canonical type 0x7ffff69be000 precision 
> 64 min <nop_expr 0x7ffff69bd000> max <cond_expr 0x7ffff69b9420>

Thanks, I just noticed the failures.  I will revert that check, it is indeed valid
for min values to not be constants (and even in C max values may be variable)

Honza

  reply	other threads:[~2015-05-04 23:50 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-03 16:08 Jan Hubicka
2015-05-04 14:21 ` Rainer Orth
2015-05-04 14:50   ` Eric Botcazou
2015-05-04 23:50     ` Jan Hubicka [this message]
2015-05-05  1:48       ` Jan Hubicka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150504235012.GA7408@kam.mff.cuni.cz \
    --to=hubicka@ucw.cz \
    --cc=ebotcazou@adacore.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=ro@cebitec.uni-bielefeld.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).