From: Jan Hubicka <hubicka@ucw.cz>
To: gcc-patches@gcc.gnu.org, jason@redhat.com
Subject: False ODR violation positives on anonymous namespace types
Date: Mon, 11 May 2015 14:28:00 -0000 [thread overview]
Message-ID: <20150511142810.GA6584@kam.mff.cuni.cz> (raw)
Jason,
I got my firefox tree building again and noticed that my patch to enable
ODR merging on non-class types caused false positives:
/aux/hubicka/trunk-install/include/c++/6.0.0/ext/new_allocator.h:66:26: warning: type â(anonymous namespace)::ObservationWithStack const&â violates one definition rule [-Wodr]
typedef const _Tp& const_reference;
^
/aux/hubicka/trunk-install/include/c++/6.0.0/ext/alloc_traits.h:110:53: note: it is defined as a pointer to different type in another translation unit
typedef const value_type& const_reference;
^
/aux/hubicka/firefox8/xpcom/build/MainThreadIOLogger.cpp:28:8: note: type âconst struct ObservationWithStackâ should match type âconst struct value_typeâ
struct ObservationWithStack
^
/aux/hubicka/trunk-install/include/c++/6.0.0/ext/alloc_traits.h:103:53: note: the incompatible type is defined here
typedef typename _Base_type::value_type value_type;
^
Here the obvious problem is that we try to merge type in anonymous namespace.
This is because at LTO time odr_type_p returns true and
type_in_anonymous_namespace returns false. odr_type_p basically checks that we
computed mangled type name for it which is done in free_lang_data as follows:
{
/* We use DECL_ASSEMBLER_NAME to hold mangled type names for One Definition Rule
merging. */
if (flag_lto_odr_type_mering
&& TREE_CODE (decl) == TYPE_DECL
&& DECL_NAME (decl)
&& decl == TYPE_NAME (TREE_TYPE (decl))
&& !is_lang_specific (TREE_TYPE (decl))
/* Save some work. Names of builtin types are always derived from
properties of its main variant. A special case are integer types
where mangling do make differences between char/signed char/unsigned
char etc. Storing name for these makes e.g.
-fno-signed-char/-fsigned-char mismatches to be handled well.
See cp/mangle.c:write_builtin_type for details. */
&& (TREE_CODE (TREE_TYPE (decl)) != VOID_TYPE
&& TREE_CODE (TREE_TYPE (decl)) != BOOLEAN_TYPE
&& TREE_CODE (TREE_TYPE (decl)) != REAL_TYPE
&& TREE_CODE (TREE_TYPE (decl)) != FIXED_POINT_TYPE)
&& !TYPE_ARTIFICIAL (TREE_TYPE (decl))
&& !variably_modified_type_p (TREE_TYPE (decl), NULL_TREE)
&& !type_in_anonymous_namespace_p (TREE_TYPE (decl)))
return !DECL_ASSEMBLER_NAME_SET_P (decl);
and obviously we are not intended to mangle tyhis type and it should be
caught by type_in_anonymous_namespace_p check:
bool
type_in_anonymous_namespace_p (const_tree t)
{
/* TREE_PUBLIC of TYPE_STUB_DECL may not be properly set for
bulitin types; those have CONTEXT NULL. */
if (!TYPE_CONTEXT (t))
return false;
return (TYPE_STUB_DECL (t) && !TREE_PUBLIC (TYPE_STUB_DECL (t)));
}
We already discussed earlier that type_in_anonymous_namespace_p is not working
on compund types, because these do not have TYPE_STUB_DECL. I tought those are
!TYPE_NAME types. What is reason for !TYPE_NAME type with no TYPE_STUB_DECL?
Is it always a compound type with typedef name?
One possible solution is to avoid producing mangled names so these won't
be odr_type_p at LTO time:
Index: tree.c
===================================================================
--- tree.c (revision 222991)
+++ tree.c (working copy)
@@ -5173,6 +5173,7 @@ need_assembler_name_p (tree decl)
&& TREE_CODE (TREE_TYPE (decl)) != REAL_TYPE
&& TREE_CODE (TREE_TYPE (decl)) != FIXED_POINT_TYPE)
&& !TYPE_ARTIFICIAL (TREE_TYPE (decl))
+ && TYPE_STUB_DECL (TREE_TYPE (decl))
&& !variably_modified_type_p (TREE_TYPE (decl), NULL_TREE)
&& !type_in_anonymous_namespace_p (TREE_TYPE (decl)))
return !DECL_ASSEMBLER_NAME_SET_P (decl);
which silence the warnings, but I think it also may cause false negatives.
Ohter option is to make type_in_anonymous_namespace_p work. The types in
question are anonymous because they are defined within anonymous template,
would the following work in type_in_anonymous_namespace_p?
+ /* Types (such as pointer_type) defined within class types may not
+ have their own TYPE_STUB_DECL. Look for the outer type. */
+ while (!TYPE_STUB_DECL (t) && TYPE_NAME (t)
+ && TREE_CODE (TYPE_NAME (t)) == TYPE_DECL
+ && DECL_CONTEXT (TYPE_NAME (t))
+ && TYPE_P (DECL_CONTEXT (TYPE_NAME (t))))
+ t = DECL_CONTEXT (TYPE_NAME (t));
Last option would be make anonymous_namespace_p to walk to compound type bases.
I made variant of this in
https://gcc.gnu.org/ml/gcc-patches/2015-05/msg00880.html
(odr_or_derived_type_p, modifying type_in_anonymous_namespace_p to work same
way is definitly easy)
What would be a preffered fix for this?
Honza
next reply other threads:[~2015-05-11 14:28 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-11 14:28 Jan Hubicka [this message]
2015-05-11 17:16 ` Jason Merrill
2015-05-11 17:46 ` Jan Hubicka
2015-05-11 17:54 ` Jason Merrill
2015-05-11 18:05 ` Jan Hubicka
2015-05-11 21:21 ` Jason Merrill
2015-05-11 21:52 ` Jan Hubicka
2015-05-12 13:51 ` Jason Merrill
2015-05-12 14:13 ` Jan Hubicka
2015-05-12 14:54 ` Jan Hubicka
2015-05-12 16:07 ` Jason Merrill
2015-05-12 16:27 ` Jan Hubicka
2015-05-12 18:40 ` Jan Hubicka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150511142810.GA6584@kam.mff.cuni.cz \
--to=hubicka@ucw.cz \
--cc=gcc-patches@gcc.gnu.org \
--cc=jason@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).