From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14730 invoked by alias); 11 May 2015 21:11:57 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 14713 invoked by uid 89); 11 May 2015 21:11:56 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: gate.crashing.org Received: from gate.crashing.org (HELO gate.crashing.org) (63.228.1.57) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Mon, 11 May 2015 21:11:55 +0000 Received: from gate.crashing.org (localhost.localdomain [127.0.0.1]) by gate.crashing.org (8.14.1/8.13.8) with ESMTP id t4BLBoFC010270; Mon, 11 May 2015 16:11:51 -0500 Received: (from segher@localhost) by gate.crashing.org (8.14.1/8.14.1/Submit) id t4BLBnpM010266; Mon, 11 May 2015 16:11:49 -0500 Date: Mon, 11 May 2015 21:11:00 -0000 From: Segher Boessenkool To: Jeff Law Cc: gcc-patches@gcc.gnu.org, rth@redhat.com Subject: Re: [PATCH] combine: Don't create (set (reg:CC) (compare (reg:CC) (const0))) Message-ID: <20150511211148.GL2521@gate.crashing.org> References: <5550E5A3.60305@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5550E5A3.60305@redhat.com> User-Agent: Mutt/1.4.2.3i X-IsSubscribed: yes X-SW-Source: 2015-05/txt/msg01016.txt.bz2 On Mon, May 11, 2015 at 11:23:47AM -0600, Jeff Law wrote: > > * combine.c (simplify_set): When generating a CC set, if the > > source already is in the correct mode, do not wrap it in a > > compare. Simplify the rest of that code. > Seems reasonable. Might not hurt to do a little testing on a cc0 target > though. I tested on mn10300, cris, and m68k. On m68k it triggers while building libgcc (for 040). I verified the transform is correct. I don't have a setup to actually bootstrap or regression check any cc0 target. A recurring theme :-( Segher