From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 91330 invoked by alias); 12 May 2015 16:24:40 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 91320 invoked by uid 89); 12 May 2015 16:24:40 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 X-HELO: nikam.ms.mff.cuni.cz Received: from nikam.ms.mff.cuni.cz (HELO nikam.ms.mff.cuni.cz) (195.113.20.16) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 12 May 2015 16:24:38 +0000 Received: by nikam.ms.mff.cuni.cz (Postfix, from userid 16202) id 1237B543AB2; Tue, 12 May 2015 18:24:34 +0200 (CEST) Date: Tue, 12 May 2015 16:27:00 -0000 From: Jan Hubicka To: Jason Merrill Cc: Jan Hubicka , gcc-patches@gcc.gnu.org Subject: Re: False ODR violation positives on anonymous namespace types Message-ID: <20150512162434.GH35526@kam.mff.cuni.cz> References: <5550E3D2.2080408@redhat.com> <20150511174607.GB59663@kam.mff.cuni.cz> <5550ECB5.8000607@redhat.com> <20150511180509.GB22960@kam.mff.cuni.cz> <55511D40.1010808@redhat.com> <20150511213949.GB35526@kam.mff.cuni.cz> <55520517.1020507@redhat.com> <20150512140313.GA26537@kam.mff.cuni.cz> <20150512145020.GF35526@kam.mff.cuni.cz> <555223E0.8030704@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <555223E0.8030704@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2015-05/txt/msg01120.txt.bz2 > Looks good. Thank you! Testing looks good, too, no false positives on Firefox. I suppose the next challenge is to make type_with_linkage_p to return false on types that was not built by C++ FE as discussed in https://gcc.gnu.org/ml/gcc-patches/2015-05/msg01023.html What would be the preferred solution? Honza > > Jason