From: Jonathan Wakely <jwakely@redhat.com>
To: libstdc++@gcc.gnu.org, gcc-patches@gcc.gnu.org
Subject: [patch] std::polar requires non-negative rho
Date: Wed, 13 May 2015 13:36:00 -0000 [thread overview]
Message-ID: <20150513133233.GH30202@redhat.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 148 bytes --]
http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2015/n4383.html#2459
Voted into the WP in Lenexa.
Tested powerpc64le-linux, comitted to trunk.
[-- Attachment #2: patch.txt --]
[-- Type: text/x-patch, Size: 805 bytes --]
commit 9bf3b9ea20334711ecdced656323f69959521a82
Author: Jonathan Wakely <jwakely@redhat.com>
Date: Wed May 13 14:18:03 2015 +0100
* include/std/complex (polar): Check for negative rho (LWG 2459).
diff --git a/libstdc++-v3/include/std/complex b/libstdc++-v3/include/std/complex
index 585683c..f2a6cf9 100644
--- a/libstdc++-v3/include/std/complex
+++ b/libstdc++-v3/include/std/complex
@@ -667,7 +667,10 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION
template<typename _Tp>
inline complex<_Tp>
polar(const _Tp& __rho, const _Tp& __theta)
- { return complex<_Tp>(__rho * cos(__theta), __rho * sin(__theta)); }
+ {
+ _GLIBCXX_DEBUG_ASSERT( __rho >= 0 );
+ return complex<_Tp>(__rho * cos(__theta), __rho * sin(__theta));
+ }
template<typename _Tp>
inline complex<_Tp>
next reply other threads:[~2015-05-13 13:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-13 13:36 Jonathan Wakely [this message]
2015-05-13 13:41 ` Daniel Krügler
2015-05-13 14:03 ` Jonathan Wakely
2015-05-13 14:11 ` Marc Glisse
2015-05-13 17:08 ` Daniel Krügler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150513133233.GH30202@redhat.com \
--to=jwakely@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=libstdc++@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).