public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
* [patch] Make std::string default constructor conditionally noexcept
@ 2015-05-13 13:37 Jonathan Wakely
  2015-05-28 12:49 ` Jonathan Wakely
  0 siblings, 1 reply; 2+ messages in thread
From: Jonathan Wakely @ 2015-05-13 13:37 UTC (permalink / raw)
  To: libstdc++, gcc-patches

[-- Attachment #1: Type: text/plain, Size: 231 bytes --]

http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2015/n4383.html#2455

Voted into the WP in Lenexa.

We already did the right thing for vector, so only basic_string needs
to change.

Tested powerpc64le-linux, committed to trunk.

[-- Attachment #2: patch.txt --]
[-- Type: text/x-patch, Size: 848 bytes --]

commit 634ed6e2d2ea4d69a29a8907044e6f68541d88aa
Author: Jonathan Wakely <jwakely@redhat.com>
Date:   Wed May 13 14:21:37 2015 +0100

    	* include/bits/basic_string.h (basic_string::basic_string()): Make
    	noexcept conditional on allocator (LWG 2455).

diff --git a/libstdc++-v3/include/bits/basic_string.h b/libstdc++-v3/include/bits/basic_string.h
index 3e3eef4..093f502 100644
--- a/libstdc++-v3/include/bits/basic_string.h
+++ b/libstdc++-v3/include/bits/basic_string.h
@@ -377,7 +377,10 @@ _GLIBCXX_BEGIN_NAMESPACE_CXX11
       /**
        *  @brief  Default constructor creates an empty string.
        */
-      basic_string() _GLIBCXX_NOEXCEPT
+      basic_string()
+#if __cplusplus >= 201103L
+      noexcept(is_nothrow_default_constructible<_Alloc>::value)
+#endif
       : _M_dataplus(_M_local_data())
       { _M_set_length(0); }
 

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [patch] Make std::string default constructor conditionally noexcept
  2015-05-13 13:37 [patch] Make std::string default constructor conditionally noexcept Jonathan Wakely
@ 2015-05-28 12:49 ` Jonathan Wakely
  0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Wakely @ 2015-05-28 12:49 UTC (permalink / raw)
  To: libstdc++, gcc-patches

On 13/05/15 14:36 +0100, Jonathan Wakely wrote:
>http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2015/n4383.html#2455
>
>Voted into the WP in Lenexa.
>
>We already did the right thing for vector, so only basic_string needs
>to change.
>
>Tested powerpc64le-linux, committed to trunk.

Also committed to gcc-5-branch.

>commit 634ed6e2d2ea4d69a29a8907044e6f68541d88aa
>Author: Jonathan Wakely <jwakely@redhat.com>
>Date:   Wed May 13 14:21:37 2015 +0100
>
>    	* include/bits/basic_string.h (basic_string::basic_string()): Make
>    	noexcept conditional on allocator (LWG 2455).
>
>diff --git a/libstdc++-v3/include/bits/basic_string.h b/libstdc++-v3/include/bits/basic_string.h
>index 3e3eef4..093f502 100644
>--- a/libstdc++-v3/include/bits/basic_string.h
>+++ b/libstdc++-v3/include/bits/basic_string.h
>@@ -377,7 +377,10 @@ _GLIBCXX_BEGIN_NAMESPACE_CXX11
>       /**
>        *  @brief  Default constructor creates an empty string.
>        */
>-      basic_string() _GLIBCXX_NOEXCEPT
>+      basic_string()
>+#if __cplusplus >= 201103L
>+      noexcept(is_nothrow_default_constructible<_Alloc>::value)
>+#endif
>       : _M_dataplus(_M_local_data())
>       { _M_set_length(0); }
> 

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-05-28 12:33 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-05-13 13:37 [patch] Make std::string default constructor conditionally noexcept Jonathan Wakely
2015-05-28 12:49 ` Jonathan Wakely

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).