public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jonathan Wakely <jwakely@redhat.com>
To: "Daniel Krügler" <daniel.kruegler@gmail.com>
Cc: libstdc++ <libstdc++@gcc.gnu.org>,
	       gcc-patches List <gcc-patches@gcc.gnu.org>
Subject: Re: [patch] std::polar requires non-negative rho
Date: Wed, 13 May 2015 14:03:00 -0000	[thread overview]
Message-ID: <20150513140025.GL30202@redhat.com> (raw)
In-Reply-To: <CAGNvRgBXU7C78bXr=tHN=rBtyQ1bTgW-Q9Ybe+ZDNh5ay4JtiQ@mail.gmail.com>

On 13/05/15 15:36 +0200, Daniel Krügler wrote:
>2015-05-13 15:32 GMT+02:00 Jonathan Wakely <jwakely@redhat.com>:
>> http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2015/n4383.html#2459
>>
>> Voted into the WP in Lenexa.
>>
>> Tested powerpc64le-linux, comitted to trunk.
>
>What about assertions regarding non-NAN rho and finite theta, as
>decided for by the LWG 2439?

I don't know how to reliably test those conditions. What if _Tp is not
a floating-point type?

The assertion I added addresses the original issue as reported
numerous times to libc++. I don't really care if it doesn't deal with
the additional preconditions added in Cologne, as users don't seem to
expect a meaningful answer for NaNs and infinities.

  reply	other threads:[~2015-05-13 14:00 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-13 13:36 Jonathan Wakely
2015-05-13 13:41 ` Daniel Krügler
2015-05-13 14:03   ` Jonathan Wakely [this message]
2015-05-13 14:11   ` Marc Glisse
2015-05-13 17:08     ` Daniel Krügler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150513140025.GL30202@redhat.com \
    --to=jwakely@redhat.com \
    --cc=daniel.kruegler@gmail.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=libstdc++@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).