From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-patches-return-397788-listarch-gcc-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 95903 invoked by alias); 13 May 2015 14:00:36 -0000
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-patches.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
Received: (qmail 95832 invoked by uid 89); 13 May 2015 14:00:32 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=1.1 required=5.0 tests=AWL,BAYES_00,SPAM_BODY,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=no version=3.3.2
X-Spam-User: qpsmtpd, 2 recipients
X-HELO: mx1.redhat.com
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 13 May 2015 14:00:30 +0000
Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t4DE0RNh018354	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL);	Wed, 13 May 2015 10:00:28 -0400
Received: from localhost (ovpn-116-139.ams2.redhat.com [10.36.116.139])	by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t4DE0QLt004702;	Wed, 13 May 2015 10:00:26 -0400
Date: Wed, 13 May 2015 14:03:00 -0000
From: Jonathan Wakely <jwakely@redhat.com>
To: Daniel =?iso-8859-1?Q?Kr=FCgler?= <daniel.kruegler@gmail.com>
Cc: libstdc++ <libstdc++@gcc.gnu.org>,        gcc-patches List <gcc-patches@gcc.gnu.org>
Subject: Re: [patch] std::polar requires non-negative rho
Message-ID: <20150513140025.GL30202@redhat.com>
References: <20150513133233.GH30202@redhat.com> <CAGNvRgBXU7C78bXr=tHN=rBtyQ1bTgW-Q9Ybe+ZDNh5ay4JtiQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1; format=flowed
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CAGNvRgBXU7C78bXr=tHN=rBtyQ1bTgW-Q9Ybe+ZDNh5ay4JtiQ@mail.gmail.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
X-SW-Source: 2015-05/txt/msg01226.txt.bz2

On 13/05/15 15:36 +0200, Daniel Krügler wrote:
>2015-05-13 15:32 GMT+02:00 Jonathan Wakely <jwakely@redhat.com>:
>> http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2015/n4383.html#2459
>>
>> Voted into the WP in Lenexa.
>>
>> Tested powerpc64le-linux, comitted to trunk.
>
>What about assertions regarding non-NAN rho and finite theta, as
>decided for by the LWG 2439?

I don't know how to reliably test those conditions. What if _Tp is not
a floating-point type?

The assertion I added addresses the original issue as reported
numerous times to libc++. I don't really care if it doesn't deal with
the additional preconditions added in Cologne, as users don't seem to
expect a meaningful answer for NaNs and infinities.