From: Jakub Jelinek <jakub@redhat.com>
To: Thomas Schwinge <thomas@codesourcery.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [gomp4] libgomp: Cope with DejaGnu having no mechanism to transfer environment variables to remote boards
Date: Thu, 14 May 2015 09:00:00 -0000 [thread overview]
Message-ID: <20150514085407.GK1751@tucnak.redhat.com> (raw)
In-Reply-To: <20150514080536.GH1751@tucnak.redhat.com>
On Thu, May 14, 2015 at 10:05:36AM +0200, Jakub Jelinek wrote:
> On Thu, May 14, 2015 at 12:10:50AM +0200, Thomas Schwinge wrote:
> > No doubt, looking forward to the day, when this can be reverted.
> >
> > libgomp/
> > * env.c (initialize_env): Remove static attribute.
> > * libgomp.map (INTERNAL): Export initialize_env.
>
> Ugh. While you achieve what you want for the remote board cases,
> doesn't this completely break all OpenMP and OpenACC programs not built
> as part of the testsuite, because initialize_env won't be called in that case?
Can't you just tweak *.exp files so that if dg-set-target-env-var is used
or some forced env var is added to the same list through other means,
you invoke on the remove side env VAR1=val1 VAR2=val2 program arguments
instead of program arguments ?
Jakub
next prev parent reply other threads:[~2015-05-14 8:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <5375D239.40605@mentor.com>
[not found] ` <537644B1.6090600@mentor.com>
[not found] ` <87ppjd61ro.fsf@schwinge.name>
[not found] ` <87lho6rfr7.fsf@schwinge.name>
[not found] ` <87vbnaph0d.fsf@schwinge.name>
2015-05-13 22:46 ` Thomas Schwinge
2015-05-14 8:10 ` Jakub Jelinek
2015-05-14 9:00 ` Jakub Jelinek [this message]
2015-05-14 9:39 ` Jakub Jelinek
2015-07-22 9:08 ` libgomp testing, RUNTESTFLAGS (was: [gomp4] libgomp: Cope with DejaGnu having no mechanism to transfer environment variables to remote boards) Thomas Schwinge
2015-07-22 8:48 ` [gomp4] libgomp: Cope with DejaGnu having no mechanism to transfer environment variables to remote boards Thomas Schwinge
[not found] ` <55A6652D.4090004@mentor.com>
2015-07-15 14:40 ` Thomas Schwinge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150514085407.GK1751@tucnak.redhat.com \
--to=jakub@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=thomas@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).