From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 79975 invoked by alias); 14 May 2015 09:26:26 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 79965 invoked by uid 89); 14 May 2015 09:26:25 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 14 May 2015 09:26:24 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t4E9QKL9014598 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 14 May 2015 05:26:20 -0400 Received: from tucnak.zalov.cz (ovpn-116-89.ams2.redhat.com [10.36.116.89]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t4E9QIn8010607 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Thu, 14 May 2015 05:26:20 -0400 Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.14.9/8.14.9) with ESMTP id t4E9QHlD028334; Thu, 14 May 2015 11:26:17 +0200 Received: (from jakub@localhost) by tucnak.zalov.cz (8.14.9/8.14.9/Submit) id t4E9QFru028333; Thu, 14 May 2015 11:26:15 +0200 Date: Thu, 14 May 2015 09:39:00 -0000 From: Jakub Jelinek To: Thomas Schwinge Cc: gcc-patches@gcc.gnu.org Subject: Re: [gomp4] libgomp: Cope with DejaGnu having no mechanism to transfer environment variables to remote boards Message-ID: <20150514092615.GL1751@tucnak.redhat.com> Reply-To: Jakub Jelinek References: <5375D239.40605@mentor.com> <537644B1.6090600@mentor.com> <87ppjd61ro.fsf@schwinge.name> <87lho6rfr7.fsf@schwinge.name> <87vbnaph0d.fsf@schwinge.name> <87iobwjfh1.fsf@schwinge.name> <20150514080536.GH1751@tucnak.redhat.com> <20150514085407.GK1751@tucnak.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150514085407.GK1751@tucnak.redhat.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-IsSubscribed: yes X-SW-Source: 2015-05/txt/msg01297.txt.bz2 On Thu, May 14, 2015 at 10:54:07AM +0200, Jakub Jelinek wrote: > On Thu, May 14, 2015 at 10:05:36AM +0200, Jakub Jelinek wrote: > > On Thu, May 14, 2015 at 12:10:50AM +0200, Thomas Schwinge wrote: > > > No doubt, looking forward to the day, when this can be reverted. > > > > > > libgomp/ > > > * env.c (initialize_env): Remove static attribute. > > > * libgomp.map (INTERNAL): Export initialize_env. > > > > Ugh. While you achieve what you want for the remote board cases, > > doesn't this completely break all OpenMP and OpenACC programs not built > > as part of the testsuite, because initialize_env won't be called in that case? > > Can't you just tweak *.exp files so that if dg-set-target-env-var is used > or some forced env var is added to the same list through other means, > you invoke on the remove side env VAR1=val1 VAR2=val2 program arguments > instead of program arguments ? Talking about the libgomp testsuite, can we rename the libgomp/testsuite/libgomp-oacc-*/*.exp files to something unique? I mean, trying to run say just the OpenMP C tests is impossible since the OpenACC merge, because RUNTESTFLAGS=c.exp runs both OpenMP and OpenACC. If it was say acc-c.exp, then you can choose if you want to test just OpenACC, or just OpenMP, both, and which particular tests more accurately. Jakub