From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-patches-return-397884-listarch-gcc-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 83779 invoked by alias); 14 May 2015 13:29:42 -0000
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-patches.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
Received: (qmail 83745 invoked by uid 89); 14 May 2015 13:29:41 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2
X-HELO: gate.crashing.org
Received: from gate.crashing.org (HELO gate.crashing.org) (63.228.1.57) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Thu, 14 May 2015 13:29:41 +0000
Received: from gate.crashing.org (localhost.localdomain [127.0.0.1])	by gate.crashing.org (8.14.1/8.13.8) with ESMTP id t4EDTNO5010046;	Thu, 14 May 2015 08:29:23 -0500
Received: (from segher@localhost)	by gate.crashing.org (8.14.1/8.14.1/Submit) id t4EDTMu5010045;	Thu, 14 May 2015 08:29:22 -0500
Date: Thu, 14 May 2015 13:36:00 -0000
From: Segher Boessenkool <segher@kernel.crashing.org>
To: Hale Wang <hale.wang@arm.com>
Cc: law@redhat.com, GCC Patches <gcc-patches@gcc.gnu.org>,        Richard Sandiford <Richard.Sandiford@arm.com>,        "'Terry Guo'" <flameroc@gmail.com>
Subject: Re: [PATCH] [gcc, combine] Backport to GCC 5.0 branch "PR46164: Don't combine the insns if a volatile register is contained".
Message-ID: <20150514132922.GD1081@gate.crashing.org>
References: <002d01d08e0a$cc6829a0$65387ce0$@arm.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <002d01d08e0a$cc6829a0$65387ce0$@arm.com>
User-Agent: Mutt/1.4.2.3i
X-IsSubscribed: yes
X-SW-Source: 2015-05/txt/msg01322.txt.bz2

On Thu, May 14, 2015 at 01:56:54PM +0800, Hale Wang wrote:
> > >> gcc/ChangeLog:
> > >> 2015-04-22 Hale Wang <hale.wang@arm.com>
> > >>                     Terry Guo  <terry.guo@arm.com>
> > >>
> > >>        PR rtl-optimization/64818
> > >>        * combine.c (can_combine_p): Don't combine user-specified register
> > if
> > >>        it is in an asm input.
> > >>
> > >> gcc/testsuite/ChangeLog:
> > >> 2015-04-22 Hale Wang <hale.wang@arm.com>
> > >>                     Terry Guo  <terry.guo@arm.com>
> > >>
> > >>        PR rtl-optimization/64818
> > >>        * gcc.target/arm/pr64818.c: New.

> This patch applies cleanly on GCC 5.0 branch. Bootstrap and regression test are OK for X86_64.
> 
> Can we backport this patch to GCC 5.0 branch?

It should be perfectly safe, and it's a pretty nasty bug.  But it is
technically not a regression (or is it?), so I'll defer to the release
managers.


Segher