From: Steve Kargl <sgk@troutmask.apl.washington.edu>
To: FX <fxcoudert@gmail.com>
Cc: fortran@gcc.gnu.org, gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] fortran/66106 -- Enforce C1202 from F2008
Date: Fri, 15 May 2015 16:09:00 -0000 [thread overview]
Message-ID: <20150515160342.GB83258@troutmask.apl.washington.edu> (raw)
In-Reply-To: <F0347FA0-1384-4C7B-85DC-9EC4FDA90FCF@gmail.com>
On Fri, May 15, 2015 at 05:45:54PM +0200, FX wrote:
> - You're missing the match.c part of the patch (I really had
> a hard time figuring out how the patch was supposed to work!
> then I read the one posted in the PR)
Whoops, sorry about that. As you can see I have small patches
sitting in my tree. I tried to untangle the 'svn diff'
> - Let's avoid the strcmp() string comparison and use
> 'op == INTRINSIC_NONE' as the condition (seems clearer and more
> efficient to me)
> - Maybe not doing all the tests (those after "The following
> if-statements") if op == INTRINSIC_NONE, as all the s2
> comparisons will be false.
> - The PR number in the ChangeLog is wrong (both times)
Whoops copy-n-paste from one log to another.
> With the above fixed, it???s OK.
> Thanks for taking care of all this!
I'll rework the patch to address your 2 suggestions.
--
Steve
next prev parent reply other threads:[~2015-05-15 16:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-15 15:34 Steve Kargl
2015-05-15 15:56 ` FX
2015-05-15 16:09 ` Steve Kargl [this message]
2015-05-15 18:17 ` FX
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150515160342.GB83258@troutmask.apl.washington.edu \
--to=sgk@troutmask.apl.washington.edu \
--cc=fortran@gcc.gnu.org \
--cc=fxcoudert@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).