From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 116196 invoked by alias); 16 May 2015 19:32:14 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 116177 invoked by uid 89); 16 May 2015 19:32:13 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 X-Spam-User: qpsmtpd, 2 recipients X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Sat, 16 May 2015 19:32:13 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (Postfix) with ESMTPS id 138A78EA38; Sat, 16 May 2015 19:32:12 +0000 (UTC) Received: from localhost (ovpn-116-43.ams2.redhat.com [10.36.116.43]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t4GJWBKI002344; Sat, 16 May 2015 15:32:11 -0400 Date: Sat, 16 May 2015 19:58:00 -0000 From: Jonathan Wakely To: =?iso-8859-1?Q?Fran=E7ois?= Dumont Cc: libstdc++@gcc.gnu.org, gcc-patches@gcc.gnu.org Subject: Re: [patch] libstdc++/66055 add missing constructors to unordered containers Message-ID: <20150516193210.GW30202@redhat.com> References: <20150514134731.GS30202@redhat.com> <55571056.2090807@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1; format=flowed Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <55571056.2090807@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-SW-Source: 2015-05/txt/msg01498.txt.bz2 On 16/05/15 11:39 +0200, François Dumont wrote: >On 14/05/2015 15:47, Jonathan Wakely wrote: >>Reported by Nathan and fixed by his patch. I added the tests. >> >>Tested powerpc64le-linux, committed to trunk. This should be >>backported too. > >While backporting to debug and profile mode I noticed that those >constructors were not the only missing ones. So here is a patch to >complete them with debug and profile modes. Great, thanks. >@@ -233,6 +222,41 @@ _GLIBCXX_BEGIN_NAMESPACE_CONTAINER > : _M_h(__l, __n, __hf, __eql, __a) > { } > >+ unordered_map(size_type __n, const allocator_type& __a) >+ : unordered_map(__n, hasher(), key_equal(), __a) >+ { } >+ >+ unordered_map(size_type __n, const hasher& __hf, >+ const allocator_type& __a) >+ : unordered_map(__n, __hf, key_equal(), __a) >+ { } >+ >+ template >+ unordered_map(_InputIterator __first, _InputIterator __last, >+ size_type __n, >+ const allocator_type& __a) >+ : unordered_map(__first, __last, __n, hasher(), key_equal(), __a) The indentation is inconsistent here, the ctor-initializer-list is indented further than necessary >@@ -891,7 +941,7 @@ _GLIBCXX_BEGIN_NAMESPACE_CONTAINER > * in the initializer list @a __l. > * > * Note that the assignment completely changes the %unordered_multiset >- * and that the resulting %unordered_set's size is the same as the number >+ * and that the resulting %unordered_multiset's size is the same as the number > * of elements assigned. Old data may be lost. Please reformat this to stay below 80 columns. OK with those two tiny adjustments, thanks!