From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-patches-return-398298-listarch-gcc-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 21224 invoked by alias); 19 May 2015 18:15:32 -0000
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-patches.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
Received: (qmail 21211 invoked by uid 89); 19 May 2015 18:15:31 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-2.8 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=no version=3.3.2
X-HELO: mx1.redhat.com
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 19 May 2015 18:15:31 +0000
Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24])	by mx1.redhat.com (Postfix) with ESMTPS id D37925A09A;	Tue, 19 May 2015 18:15:29 +0000 (UTC)
Received: from greed.delorie.com (ovpn-113-25.phx2.redhat.com [10.3.113.25])	by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t4JIFSmK032107	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO);	Tue, 19 May 2015 14:15:29 -0400
Received: from greed.delorie.com (greed.delorie.com [127.0.0.1])	by greed.delorie.com (8.14.4/8.14.4) with ESMTP id t4JIFS9k002463;	Tue, 19 May 2015 14:15:28 -0400
Received: (from dj@localhost)	by greed.delorie.com (8.14.4/8.14.4/Submit) id t4JIFRGn002461;	Tue, 19 May 2015 14:15:27 -0400
Date: Tue, 19 May 2015 18:16:00 -0000
Message-Id: <201505191815.t4JIFRGn002461@greed.delorie.com>
From: DJ Delorie <dj@redhat.com>
To: Yunlian Jiang <yunlian@google.com>
CC: iant@google.com, gcc-patches@gcc.gnu.org
In-reply-to:	<CAMsPy2s5_mE6QCvXj5DEQxGGK6XhpPUMbzxQqqzEOd+f3gaEjg@mail.gmail.com>	(message from Yunlian Jiang on Tue, 19 May 2015 11:08:47 -0700)
Subject: Re: [PATCH/libiberty] fix build of gdb/binutils with clang.
References: <CAMsPy2vps4WX9ax-JfPCGdWbRw=deyu+OuqpgojSJFSe6e+HHg@mail.gmail.com>	<CAKOQZ8wXKGAxKgcetJxPPWXgxaeNrbLf-E_o6Tz2zbjYF6VfQg@mail.gmail.com>	<CAMsPy2v+MduooHaBA8hhiTcrq_1NeQm1X-LnOrMEoouUQii4kg@mail.gmail.com>	<CAKOQZ8z7ME_yEbW3YgMWCLyRVz+w3wjYz7LNayBBBmC1atFYHA@mail.gmail.com>	<CAMsPy2s2A8U-vTE8u9y+P+xmESKMSuHD=6RV798KNEQKbZdXUg@mail.gmail.com>	<CAKOQZ8ybeY+6bC0XXVy4Ge3QPEcg6XcvhwBuXQjHhLRTMabm8g@mail.gmail.com>	<CAMsPy2s9vwa+Y3fR4Xc8k5jnJG__jwWAbF2y0bbSfmz0bEYfYQ@mail.gmail.com>	<CAKOQZ8zw5TUQ5uP60CuSrAokqohR1_Aq=F5-cGPYqSnL--jPzQ@mail.gmail.com> <CAMsPy2s5_mE6QCvXj5DEQxGGK6XhpPUMbzxQqqzEOd+f3gaEjg@mail.gmail.com>
X-IsSubscribed: yes
X-SW-Source: 2015-05/txt/msg01736.txt.bz2


> If the other c file only includes libiberty.h and does not include the
> libiberty/config.h and

In general, such "other c files" should have their own config.h that
does the same test and has its own HAVE_DECL_ASPRINTF.

That way, the config.h matches the compiler options being used, and
not the compiler options libiberty's build used.