From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13727 invoked by alias); 20 May 2015 14:33:02 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 13708 invoked by uid 89); 20 May 2015 14:33:02 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 20 May 2015 14:33:01 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (Postfix) with ESMTPS id 102232BB38C; Wed, 20 May 2015 14:33:00 +0000 (UTC) Received: from tucnak.zalov.cz (ovpn-116-89.ams2.redhat.com [10.36.116.89]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t4KEWvc5015679 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Wed, 20 May 2015 10:32:59 -0400 Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.14.9/8.14.9) with ESMTP id t4KEWuch018589; Wed, 20 May 2015 16:32:57 +0200 Received: (from jakub@localhost) by tucnak.zalov.cz (8.14.9/8.14.9/Submit) id t4KEWtnv018588; Wed, 20 May 2015 16:32:55 +0200 Date: Wed, 20 May 2015 14:36:00 -0000 From: Jakub Jelinek To: Cesar Philippidis Cc: Thomas Schwinge , "gcc-patches@gcc.gnu.org" Subject: Re: [patch,gomp4] error on invalid acc loop clauses Message-ID: <20150520143255.GJ1751@tucnak.redhat.com> Reply-To: Jakub Jelinek References: <5556368D.7010904@codesourcery.com> <87mw0zirnq.fsf@schwinge.name> <555C977F.4000001@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <555C977F.4000001@codesourcery.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-IsSubscribed: yes X-SW-Source: 2015-05/txt/msg01842.txt.bz2 On Wed, May 20, 2015 at 07:17:35AM -0700, Cesar Philippidis wrote: > > ..., and this: why not do such nesting checking in > > gcc/omp-low.c:check_omp_nesting_restrictions? Currently (changed by > > Bernd in internal r442824, 2014-11-29) we're allowing all > > OpenACC-inside-OpenACC nesting -- shouldn't that be changed instead of > > repeating the checks in every front end (Jakub?)? > > The fortran front end is doing this. Also, Joseph told me the front ends > should report error messages when possible. I have no problems reverting > back to the original behavior though. For OpenMP/OpenACC, there is still lots of diagnostics emitted during gimplification and at the start of the omp lowering phases, so for diagnostics purposes you can consider them as part of a common layer for all the 3 FEs. Jakub