From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12708 invoked by alias); 21 May 2015 11:10:16 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 12696 invoked by uid 89); 21 May 2015 11:10:15 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 21 May 2015 11:10:14 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t4LBABjv023981 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 21 May 2015 07:10:12 -0400 Received: from tucnak.zalov.cz (ovpn-116-89.ams2.redhat.com [10.36.116.89]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t4LBAA9o014583 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Thu, 21 May 2015 07:10:11 -0400 Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.14.9/8.14.9) with ESMTP id t4LBA8Ce002239; Thu, 21 May 2015 13:10:08 +0200 Received: (from jakub@localhost) by tucnak.zalov.cz (8.14.9/8.14.9/Submit) id t4LBA5Z8002218; Thu, 21 May 2015 13:10:05 +0200 Date: Thu, 21 May 2015 11:42:00 -0000 From: Jakub Jelinek To: Thomas Schwinge Cc: Julian Brown , gcc-patches@gcc.gnu.org, Kirill Yukhin , Ilya Verbin Subject: Re: acc_on_device for device_type_host_nonshm Message-ID: <20150521111005.GS1751@tucnak.redhat.com> Reply-To: Jakub Jelinek References: <20150401132025.GM19273@tucnak.redhat.com> <20150406124557.GA5541@msticlxl57.ims.intel.com> <20150407152645.GJ19273@tucnak.redhat.com> <20150408153142.128b97b9@octopus> <20150408145856.GA19410@msticlxl57.ims.intel.com> <20150414151502.5ca882a4@octopus> <87pp76zpep.fsf@schwinge.name> <20150417131619.GP1725@tucnak.redhat.com> <20150507193226.6aee40c5@octopus> <87h9r6nqh7.fsf@kepler.schwinge.homeip.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87h9r6nqh7.fsf@kepler.schwinge.homeip.net> User-Agent: Mutt/1.5.23 (2014-03-12) X-IsSubscribed: yes X-SW-Source: 2015-05/txt/msg01942.txt.bz2 On Thu, May 21, 2015 at 01:02:12PM +0200, Thomas Schwinge wrote: > Hi! > > On Thu, 7 May 2015 19:32:26 +0100, Julian Brown wrote: > > Here's a new version of the patch [...] > > > OK for trunk? > > Makes sense to me (with just a request to drop the testsuite changes, see > below), to get the existing regressions under control. Jakub? Ok for trunk. > > > PR libgomp/65742 > > > > gcc/ > > * builtins.c (expand_builtin_acc_on_device): Don't use open-coded > > sequence for !ACCEL_COMPILER. > > > > libgomp/ > > * oacc-init.c (plugin/plugin-host.h): Include. > > (acc_on_device): Check whether we're in an offloaded region for > > host_nonshm > > plugin. Don't use __builtin_acc_on_device. > > * plugin/plugin-host.c (GOMP_OFFLOAD_openacc_parallel): Set > > nonshm_exec flag in thread-local data. > > (GOMP_OFFLOAD_openacc_create_thread_data): Allocate thread-local > > data for host_nonshm plugin. > > (GOMP_OFFLOAD_openacc_destroy_thread_data): Free thread-local data > > for host_nonshm plugin. > > * plugin/plugin-host.h: New. > > * testsuite/libgomp.oacc-c-c++-common/acc_on_device-1.c: Remove > > -fno-builtin-acc_on_device flag. > > * testsuite/libgomp.oacc-c-c++-common/if-1.c: Likewise. > > * testsuite/libgomp.oacc-fortran/acc_on_device-1-1.f90: Remove > > comment re: acc_on_device builtin. > > * testsuite/libgomp.oacc-fortran/acc_on_device-1-2.f: Likewise. > > * testsuite/libgomp.oacc-fortran/acc_on_device-1-3.f: Likewise.> commit adccf2e7d313263d585f63e752a4d36653d47811 Jakub