From: Jan Hubicka <hubicka@ucw.cz>
To: Richard Biener <rguenther@suse.de>
Cc: Jan Hubicka <hubicka@ucw.cz>, gcc-patches@gcc.gnu.org
Subject: Re: Calculate TYPE_CANONICAL only for types that can be accessed in memory
Date: Fri, 22 May 2015 12:30:00 -0000 [thread overview]
Message-ID: <20150522120401.GC75713@kam.mff.cuni.cz> (raw)
In-Reply-To: <alpine.LSU.2.11.1505221003410.30088@zhemvz.fhfr.qr>
> > + /* No need for canonical types of functions and methods; those are never
> > + accessed as memory locations. */
> > + if (TREE_CODE (t) == FUNCTION_TYPE || TREE_CODE (t) == METHOD_TYPE)
> > + return;
>
> Just occured to me that it might make sense to remove the
> FUNCTION/METHOD_TYPE case in useless_type_conversion_p (I wonder
> in which cases we enter up in that path...).
Yes, I think that is unreachable (it was used only by that ignored code path in
ipa-symtab.c) and I also had patch for it somewhere. Will look it up at
afternoon (I am teaching at morning).
I think useless_type_conversion_p should also just work on types that do have
memory representation.
Honza
prev parent reply other threads:[~2015-05-22 12:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-21 18:26 Jan Hubicka
2015-05-22 8:28 ` Richard Biener
2015-05-22 12:21 ` Jan Hubicka
2015-05-24 13:33 ` H.J. Lu
2015-05-24 14:47 ` H.J. Lu
2015-05-22 12:30 ` Jan Hubicka [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150522120401.GC75713@kam.mff.cuni.cz \
--to=hubicka@ucw.cz \
--cc=gcc-patches@gcc.gnu.org \
--cc=rguenther@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).