From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-patches-return-398662-listarch-gcc-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 103732 invoked by alias); 22 May 2015 12:04:05 -0000
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-patches.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
Received: (qmail 103721 invoked by uid 89); 22 May 2015 12:04:05 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,T_RP_MATCHES_RCVD autolearn=no version=3.3.2
X-HELO: nikam.ms.mff.cuni.cz
Received: from nikam.ms.mff.cuni.cz (HELO nikam.ms.mff.cuni.cz) (195.113.20.16) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 22 May 2015 12:04:04 +0000
Received: by nikam.ms.mff.cuni.cz (Postfix, from userid 16202)	id 7128D543137; Fri, 22 May 2015 14:04:01 +0200 (CEST)
Date: Fri, 22 May 2015 12:30:00 -0000
From: Jan Hubicka <hubicka@ucw.cz>
To: Richard Biener <rguenther@suse.de>
Cc: Jan Hubicka <hubicka@ucw.cz>, gcc-patches@gcc.gnu.org
Subject: Re: Calculate TYPE_CANONICAL only for types that can be accessed in memory
Message-ID: <20150522120401.GC75713@kam.mff.cuni.cz>
References: <20150521181437.GB8821@kam.mff.cuni.cz> <alpine.LSU.2.11.1505221003410.30088@zhemvz.fhfr.qr>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <alpine.LSU.2.11.1505221003410.30088@zhemvz.fhfr.qr>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-SW-Source: 2015-05/txt/msg02100.txt.bz2

> > +  /* No need for canonical types of functions and methods; those are never
> > +     accessed as memory locations.  */
> > +  if (TREE_CODE (t) == FUNCTION_TYPE || TREE_CODE (t) == METHOD_TYPE)
> > +    return;
> 
> Just occured to me that it might make sense to remove the
> FUNCTION/METHOD_TYPE case in useless_type_conversion_p (I wonder
> in which cases we enter up in that path...).

Yes, I think that is unreachable (it was used only by that ignored code path in
ipa-symtab.c) and I also had patch for it somewhere.  Will look it up at
afternoon (I am teaching at morning).
I think useless_type_conversion_p should also just work on types that do have
memory representation.

Honza