From: Andre Vehreschild <vehre@gmx.de>
To: Paul Richard Thomas <paul.richard.thomas@gmail.com>
Cc: "fortran@gcc.gnu.org" <fortran@gcc.gnu.org>,
gcc-patches <gcc-patches@gcc.gnu.org>,
Damian Rouson <damian@sourceryinstitute.org>
Subject: Re: [Patch, fortran] PR66079 - [6 Regression] memory leak with source allocation in internal subprogram
Date: Sat, 23 May 2015 21:30:00 -0000 [thread overview]
Message-ID: <20150523195252.22647b46@vepi2> (raw)
In-Reply-To: <CAGkQGiJ66iHS3J9d9H+f6e=ZeSO60ktDat-4e5TAjeO9W8oZFg@mail.gmail.com>
Hi Paul,
does this patch apply to current trunk cleanly? I get an issue with the last
hunk, because all of the prerequisites are gone since r223445. The string copy
is completely handled by the trans_assignment at the bottom of the if
(code->expr3) block. Therefore I doubt the patches last hunk is needed any
longer.
Do you have an example why this hunk is needed?
Index: gcc/fortran/trans-stmt.c
===================================================================
*** gcc/fortran/trans-stmt.c (revision 223233)
--- gcc/fortran/trans-stmt.c (working copy)
*************** gfc_trans_allocate (gfc_code * code)
*** 5200,5206 ****
}
/* else expr3 = NULL_TREE set above. */
}
! else
{
/* In all other cases evaluate the expr3 and create a
temporary. */
--- 5200,5207 ----
}
/* else expr3 = NULL_TREE set above. */
}
! else if (!(code->expr3->ts.type == BT_DERIVED
! && code->expr3->ts.u.derived->attr.alloc_comp))
{
/* In all other cases evaluate the expr3 and create a
temporary. */
When I get the code right, than all derived-typed source= expressions that have
an allocatable component will not be prepared for copy to the allocated object.
This also means, that functions returning an object of such a type are called
multiple times. Once for each object to allocate. Is this really desired?
I am sorry, that I have to say that, but the check2305.diff file does not bring
the testcase with it.
Regards,
Andre
On Sat, 23 May 2015 14:48:53 +0200
Paul Richard Thomas <paul.richard.thomas@gmail.com> wrote:
> Dear All,
>
> This patch started out fixing a single source of memory leak and then
> went on to fix various other issues that I found upon investigation.
>
> The fortran ChangeLog entry is sufficiently descripive that I do not
> think that there is a need to say more.
>
> Bootstrapped and regtested on x86_64/FC21 - OK for trunk?
>
> I am rather sure that some of the issues go further back than 6.0. I
> will investigate what should be fixed for 5.2.
>
> Cheers
>
> Paul
>
> 2015-05-23 Paul Thomas <pault@gcc.gnu.org>
>
> PR fortran/66079
> * trans-expr.c (gfc_conv_procedure_call): Allocatable scalar
> function results must be freed and nullified after use. Create
> a temporary to hold the result to prevent duplicate calls.
> * trans-stmt.c (gfc_trans_allocate): Prevent memory leaks by
> not evaluating expr3 for scalar derived types with allocatable
> components. Fixed character length allocatable results and
> dummies need to be dereferenced. Also, if al_len is NULL use
> memsz for the string copy.
>
> 2015-05-23 Paul Thomas <pault@gcc.gnu.org>
>
> PR fortran/66079
> * gfortran.dg/allocatable_scalar_13.f90: New test
--
Andre Vehreschild * Email: vehre ad gmx dot de
next prev parent reply other threads:[~2015-05-23 17:53 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-23 17:53 Paul Richard Thomas
2015-05-23 21:30 ` Andre Vehreschild [this message]
2015-05-23 21:35 ` Paul Richard Thomas
2015-05-24 18:55 ` Andre Vehreschild
2015-05-24 11:25 ` Paul Richard Thomas
2015-05-25 10:25 ` Paul Richard Thomas
2015-05-25 11:52 ` Andre Vehreschild
2015-05-25 18:09 ` Mikael Morin
2015-05-27 8:38 ` Paul Richard Thomas
2015-05-27 14:16 ` Andre Vehreschild
2015-05-27 16:42 ` Mikael Morin
2015-05-27 21:28 ` Steve Kargl
2015-05-28 15:22 ` Mikael Morin
2015-05-28 15:24 ` Andre Vehreschild
2015-05-25 18:08 ` Mikael Morin
2015-05-25 18:41 ` Steve Kargl
2015-06-11 16:00 ` Paul Richard Thomas
2015-10-18 20:04 ` Paul Richard Thomas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150523195252.22647b46@vepi2 \
--to=vehre@gmx.de \
--cc=damian@sourceryinstitute.org \
--cc=fortran@gcc.gnu.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=paul.richard.thomas@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).