From: Jakub Jelinek <jakub@redhat.com>
To: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] PR 66215: S390: Fix placement of post-label NOPs with -mhotpatch
Date: Fri, 29 May 2015 12:35:00 -0000 [thread overview]
Message-ID: <20150529112848.GX10247@tucnak.redhat.com> (raw)
In-Reply-To: <20150529105700.GA14508@linux.vnet.ibm.com>
On Fri, May 29, 2015 at 11:57:00AM +0100, Dominik Vogt wrote:
> 2015-05-29 Dominik Vogt <vogt@linux.vnet.ibm.com>
>
> PR target0/66215
Please remove the 0 above.
> * gcc.target/s390/hotpatch-1.c: Improve to detect multi-line patterns.
> * gcc.target/s390/hotpatch-2.c: Likewise.
> * gcc.target/s390/hotpatch-3.c: Likewise.
> * gcc.target/s390/hotpatch-4.c: Likewise.
> * gcc.target/s390/hotpatch-5.c: Likewise.
> * gcc.target/s390/hotpatch-6.c: Likewise.
> * gcc.target/s390/hotpatch-7.c: Likewise.
> * gcc.target/s390/hotpatch-8.c: Likewise.
> * gcc.target/s390/hotpatch-9.c: Likewise.
> * gcc.target/s390/hotpatch-14.c: Likewise.
> * gcc.target/s390/hotpatch-15.c: Likewise.
> * gcc.target/s390/hotpatch-16.c: Likewise.
> * gcc.target/s390/hotpatch-19.c:Likewise.
> * gcc.target/s390/hotpatch-25.c:Likewise.
Missing spaces after : . Furthermore, it is very unusual
to list the same file more than once in the ChangeLog of the
same patch. And the descriptions really don't match the changes
in the tests (e.g. hotpatch-1.c only has the -O* removal,
and -13 has also a dg-final line removal, ditto -25). From what
I can see, some tests are new, those are ok in the ChangeLog as
is (except that hotpatch-28.c is missing),
in other tests you've removed optimization options from dg-options,
and in some tests tweaked scan-assembler regexps, and in others
removed some dg-final directives.
So IMHO you want:
* gcc.target/s390/hotpatch-1.c: Remove optimization options from
dg-options.
* gcc.target/s390/hotpatch-10.c: Likewise.
* gcc.target/s390/hotpatch-11.c: Likewise.
* gcc.target/s390/hotpatch-12.c: Likewise.
* gcc.target/s390/hotpatch-17.c: Likewise.
* gcc.target/s390/hotpatch-18.c: Likewise.
* gcc.target/s390/hotpatch-20.c: Likewise.
* gcc.target/s390/hotpatch-21.c: Likewise.
* gcc.target/s390/hotpatch-22.c: Likewise.
* gcc.target/s390/hotpatch-23.c: Likewise.
* gcc.target/s390/hotpatch-24.c: Likewise.
* gcc.target/s390/hotpatch-2.c: Likewise. Adjust scan-assembler
to check for the exact nops too.
* gcc.target/s390/hotpatch-3.c: Likewise.
* gcc.target/s390/hotpatch-4.c: Likewise.
* gcc.target/s390/hotpatch-5.c: Likewise.
* gcc.target/s390/hotpatch-6.c: Likewise.
* gcc.target/s390/hotpatch-7.c: Likewise.
* gcc.target/s390/hotpatch-8.c: Likewise.
* gcc.target/s390/hotpatch-9.c: Likewise.
* gcc.target/s390/hotpatch-14.c: Likewise.
* gcc.target/s390/hotpatch-15.c: Likewise.
* gcc.target/s390/hotpatch-16.c: Likewise.
* gcc.target/s390/hotpatch-19.c: Likewise.
* gcc.target/s390/hotpatch-25.c: Likewise. Remove
scan-assembler-times counting number of .align directives.
* gcc.target/s390/hotpatch-13.c: Remove optimization options from
dg-options. Remove scan-assembler-times counting number of .align
directives.
* gcc.target/s390/hotpatch-26.c: New file.
* gcc.target/s390/hotpatch-27.c: New file.
* gcc.target/s390/hotpatch-28.c: New file.
* gcc.target/s390/s390.exp: Run hotpatch-*.c tests as torture tests
using -Os -O0 -O1 -O2 -O3 options.
> + /* Emit NOPs
> + * 1. inside the area covered by debug information to allow setting
> + * breakpoints at the NOPs,
> + * 2. before any insn which results in an asm instruction,
> + * 3. before in-function labels to avoid jumping to the NOPs, for
> + * example as part of a loop,
> + * 4. before any barrier in case the function is completely empty
> + * (gcc_unreachable ()) and has neither internal labels nor active
> + * insns. */
I believe the the above comment isn't formatted like comments in GCC usually
are, can you please replace the *s at the beginning of lines (after
whitespace) with spaces? Also, please use __builtin_unreachable ()
instead of gcc_unreachable (). No need to retest the patch for ChangeLog
and comment only changes.
And I'll defer the final ack to s390 maintainers.
Jakub
next prev parent reply other threads:[~2015-05-29 11:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-29 11:52 Dominik Vogt
2015-05-29 12:35 ` Jakub Jelinek [this message]
2015-05-29 15:18 ` Dominik Vogt
2015-05-29 15:28 ` Andreas Krebbel
2015-06-01 8:33 ` Dominik Vogt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150529112848.GX10247@tucnak.redhat.com \
--to=jakub@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).