public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jonathan Wakely <jwakely@redhat.com>
To: Renlin Li <renlin.li@arm.com>
Cc: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>,
	       "libstdc++@gcc.gnu.org" <libstdc++@gcc.gnu.org>,
	       Marcus Shawcroft <marcus.shawcroft@gmail.com>
Subject: Re: [PATCH][libstdc++-v3] Add _GLIBCXX_HAVE_LIMIT_FSIZE to guard 27_io/fpos/14775.cc
Date: Mon, 01 Jun 2015 15:58:00 -0000	[thread overview]
Message-ID: <20150601155854.GD17401@redhat.com> (raw)
In-Reply-To: <5549CC2E.2060605@arm.com>

On 06/05/15 09:09 +0100, Renlin Li wrote:
>Hi all,
>
>This is a simple patch to add _GLIBCXX_HAVE_LIMIT_FSIZE to guard the test.
>
>In libstdc++-v3/testsuite/util/testsuite_hooks.cc. set_file_limit() 
>function is nullified when either _GLIBCXX_RES_LIMITS or 
>_GLIBCXX_HAVE_LIMIT_FSIZE is not defined.
>_GLIBCXX_USE_LFS can cover _GLIBCXX_RES_LIMITS, however, 
>_GLIBCXX_HAVE_LIMIT_FSIZE is not checked.
>
>The complete condition for correct execution of this test case is 
>that, those two macros are both defined.
>
>Is Okay to commit?

OK.

>Regards,
>Renlin Li
>
>libstdc++-v3/ChangeLog:
>
>2015-05-06  Renlin Li  <renlin.li@arm.com>
>
>    * testsuite/27_io/fpos/14775.cc: Add _GLIBCXX_HAVE_LIMIT_FSIZE check.

>diff --git a/libstdc++-v3/testsuite/27_io/fpos/14775.cc b/libstdc++-v3/testsuite/27_io/fpos/14775.cc
>index b700868..69c0a6a 100644
>--- a/libstdc++-v3/testsuite/27_io/fpos/14775.cc
>+++ b/libstdc++-v3/testsuite/27_io/fpos/14775.cc
>@@ -27,7 +27,7 @@
> // Basic test for LFS support.
> void test01()
> {
>-#ifdef _GLIBCXX_USE_LFS
>+#if defined (_GLIBCXX_USE_LFS) && defined (_GLIBCXX_HAVE_LIMIT_FSIZE)
>   using namespace std;
>   bool test __attribute__((unused)) = true;
> 

  parent reply	other threads:[~2015-06-01 15:58 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-06  8:09 Renlin Li
2015-06-01 15:00 ` [Ping][PATCH][libstdc++-v3] " Renlin Li
2015-06-01 15:58 ` Jonathan Wakely [this message]
2015-06-04 15:53   ` [PATCH][libstdc++-v3] " Renlin Li
2015-06-05  8:29     ` Jonathan Wakely

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150601155854.GD17401@redhat.com \
    --to=jwakely@redhat.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=libstdc++@gcc.gnu.org \
    --cc=marcus.shawcroft@gmail.com \
    --cc=renlin.li@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).