From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 74048 invoked by alias); 3 Jun 2015 09:39:31 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 74037 invoked by uid 89); 3 Jun 2015 09:39:30 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=1.4 required=5.0 tests=AWL,BAYES_50,FAKE_REPLY_C,KAM_LAZY_DOMAIN_SECURITY autolearn=no version=3.3.2 X-HELO: melchior.cuivre.fr.eu.org Received: from melchior.cuivre.fr.eu.org (HELO melchior.cuivre.fr.eu.org) (194.98.77.222) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 03 Jun 2015 09:39:28 +0000 Received: from melamine.cuivre.fr.eu.org (unknown [10.3.0.2]) by melchior.cuivre.fr.eu.org (Postfix) with ESMTPS id 7905C3ADB3; Wed, 3 Jun 2015 11:39:24 +0200 (CEST) Received: by melamine.cuivre.fr.eu.org (Postfix, from userid 1000) id 4A3FD38EB61; Wed, 3 Jun 2015 11:39:24 +0200 (CEST) Date: Wed, 03 Jun 2015 09:41:00 -0000 From: Thomas Quinot To: Eric Botcazou , Arnaud Charlet Cc: John Marino , gcc-patches@gcc.gnu.org Subject: Re: [patch] Implement Ada support for DragonFly, improve it for FreeBSD Message-ID: <20150603093924.GC47219@melamine.cuivre.fr.eu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150603090358.GB28561@adacore.com> <20777268.lEEs1vboLO@polaris> User-Agent: Mutt/1.5.23 (2014-03-12) X-SW-Source: 2015-06/txt/msg00293.txt.bz2 * Eric Botcazou, 2015-06-03 : > > Note 2) I removed reference to FreeBSD 6 and earlier. These platforms > > have been EOL for years (FreeBSD 8 is EOL in 4 weeks) > > > > Note 3) FreeBSD should have switched to use errno years ago, this patch > > does that now. > > > > Note 4) For all BSD except DragonFly (which doesn't support i386 > > anymore), the GCC_UNWINDER is specified for i386 platforms. It wasn't > > specified before. > > > > Note 5) All the ce/cxa/cxg tests that failed on i386-FreeBSD are related > > to the 53-bit float mantissa issue on FreeBSD. This is resolved by my > > GNAT-AUX repository changes so the tests pass without compromising other > > compilers, but those patches are out of scope of this set. > > I'm not a specialist of FreeBSD so Thomas is Cced. The original message is: > https://gcc.gnu.org/ml/gcc-patches/2015-05/msg02830.html Patch looks good to me. The story with floats is that on FreeBSD, the i386 FPU is set to 53-bit floats, but the GNAT runtime library always issues a "finit" instruction to reset it to full precision, so we need to reset TARGET_96_ROUND_53_LONG_DOUBLE to 0. * Arnaud Charlet, 2015-06-03 : > > In all likelihood, I would be the first to discover the breakage and > > also the most likely to submit the patch. This covers all three targets > > (both FreeBSD and the one DragonFly). > > OK, as long as this happens and the files do not bitrot, that's fine with me. > What I want to avoid is a one time submit and no follow ups afterwards, and > files which no longer work after some time, with nobody bothering fixing > them. John has been actively maintaining these changes for the past few years, so I'm confident these files won't bitrot. -- Thomas Quinot, Ph.D. ** quinot@adacore.com ** Senior Software Engineer AdaCore -- Paris, France -- New York, USA