public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jonathan Wakely <jwakely@redhat.com>
To: Martin Sebor <msebor@redhat.com>
Cc: libstdc++@gcc.gnu.org, gcc-patches@gcc.gnu.org
Subject: Re: [patch] libstdc++/66030 fix codecvt exports for mingw32
Date: Tue, 09 Jun 2015 09:42:00 -0000	[thread overview]
Message-ID: <20150609085850.GZ12728@redhat.com> (raw)
In-Reply-To: <5575BBF1.8080704@redhat.com>

On 08/06/15 09:59 -0600, Martin Sebor wrote:
>On 06/08/2015 09:12 AM, Jonathan Wakely wrote:
>>The linker script assumes that std::mbstate_t has the name __mbstate_t
>>for linkage purposes, but that's not necessarily true. For mingw32
>>it's just a typedef for int, so the patterns don't match.
>>
>>This adds a new mingw32-specific pattern for codecvt_byname's
>>constructors and destructors, and relaxes the patterns for
>>codecvt<charNN_t, char, mbstate_t> so they match __mbstate_t or int.
>
>As a data point, in case other targets have a similar issue,
>mbstate_t is a typedef for char* on AIX, and (based on my
>old notes) typedef struct mbstate_t on HP-UX.
>
>(It is a typedef struct __mbstate_t on Darwin and Solaris.)

That is useful, thanks.

AIX and HP-UX don't use that linker script, so it's not a problem (for
now) that it assumes __mbstate_t.

  reply	other threads:[~2015-06-09  8:58 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-08 15:31 Jonathan Wakely
2015-06-08 16:01 ` Martin Sebor
2015-06-09  9:42   ` Jonathan Wakely [this message]
2015-06-15 12:53 ` Jonathan Wakely

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150609085850.GZ12728@redhat.com \
    --to=jwakely@redhat.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=libstdc++@gcc.gnu.org \
    --cc=msebor@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).