From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21196 invoked by alias); 9 Jun 2015 08:58:54 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 21167 invoked by uid 89); 9 Jun 2015 08:58:53 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.0 required=5.0 tests=AWL,BAYES_50,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 X-Spam-User: qpsmtpd, 2 recipients X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 09 Jun 2015 08:58:53 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (Postfix) with ESMTPS id D6FF6B72D9; Tue, 9 Jun 2015 08:58:51 +0000 (UTC) Received: from localhost (ovpn-116-119.ams2.redhat.com [10.36.116.119]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t598wo7T030389; Tue, 9 Jun 2015 04:58:51 -0400 Date: Tue, 09 Jun 2015 09:42:00 -0000 From: Jonathan Wakely To: Martin Sebor Cc: libstdc++@gcc.gnu.org, gcc-patches@gcc.gnu.org Subject: Re: [patch] libstdc++/66030 fix codecvt exports for mingw32 Message-ID: <20150609085850.GZ12728@redhat.com> References: <20150608151218.GY12728@redhat.com> <5575BBF1.8080704@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <5575BBF1.8080704@redhat.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-SW-Source: 2015-06/txt/msg00639.txt.bz2 On 08/06/15 09:59 -0600, Martin Sebor wrote: >On 06/08/2015 09:12 AM, Jonathan Wakely wrote: >>The linker script assumes that std::mbstate_t has the name __mbstate_t >>for linkage purposes, but that's not necessarily true. For mingw32 >>it's just a typedef for int, so the patterns don't match. >> >>This adds a new mingw32-specific pattern for codecvt_byname's >>constructors and destructors, and relaxes the patterns for >>codecvt so they match __mbstate_t or int. > >As a data point, in case other targets have a similar issue, >mbstate_t is a typedef for char* on AIX, and (based on my >old notes) typedef struct mbstate_t on HP-UX. > >(It is a typedef struct __mbstate_t on Darwin and Solaris.) That is useful, thanks. AIX and HP-UX don't use that linker script, so it's not a problem (for now) that it assumes __mbstate_t.