public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jakub Jelinek <jakub@redhat.com>
To: Ilya Verbin <iverbin@gmail.com>
Cc: Thomas Schwinge <thomas@codesourcery.com>,
	gcc-patches@gcc.gnu.org,
	       Kirill Yukhin <kirill.yukhin@gmail.com>,
	       Richard Henderson <rth@redhat.com>
Subject: Re: [gomp4.1] Initial support for some OpenMP 4.1 construct parsing
Date: Tue, 09 Jun 2015 20:25:00 -0000	[thread overview]
Message-ID: <20150609202426.GG10247@tucnak.redhat.com> (raw)
In-Reply-To: <20150609183608.GA47936@msticlxl57.ims.intel.com>

On Tue, Jun 09, 2015 at 09:36:08PM +0300, Ilya Verbin wrote:
> On Wed, Apr 29, 2015 at 14:06:44 +0200, Jakub Jelinek wrote:
> > [...] The draft requires only alloc or to
> > (or always, variants) for enter data and only from or delete (or always,
> > variants) for exit data, so in theory it is possible to figure that from
> > the call without extra args, but not so for update - enter data is supposed
> > to increment reference counts, exit data decrement. [...]
> 
> TR3.pdf also says about 'release' map-type for exit data, but it is not
> described in the document.

Seems that is the case even in the latest draft.  Can you file a ticket
for this or discuss on omp-lang?  Or should I?

> > [...] And, we'll need new
> > arguments for async (pass through info that it is async (nowait) or sync,
> > and the depend clause address(es)).
> 
> I don't quite understand from "If a depend clause is present, then it is treated
> as if it had appeared on the implicit task construct that encloses the target
> construct", is
> 
>   #pragma omp target depend(inout: x)
> 
> equivalent to
> 
>   #pragma omp task depend(inout: x)
>   #pragma omp target
> 
> or not?
> 
> In other words, can't we just generate GOMP_task (...) with GOMP_target (...)
> inside, without any new arguments?

No, that would be an explicit task.  Furthermore, the implicit task isn't
on the host side, but on the offloading device side.  The implicit task is
what is executed when you enter the #pragma omp target.  Ignoring the teams
construct which is there mainly for NVidia GPGPUs, when you enter the
#pragma omp target construct, there is an implicit parallel with
num_threads(1) (like there is an implicit parallel with num_threads(1)
when you enter main () of a host program), and that implicit parallel has
a single implicit task, which executes the statements inside of #pragma
omp target body, until you encounter #pragma omp teams or #pragma omp
parallel.  And the above statement simply says that no statements from
the #pragma omp target body are executed until the depend dependency is
satisfied.  Whether these dependencies are host addresses, or offloading
device addresses, is something that really needs to be figured out, I admit
I haven't read the whole async offloading text carefully yet, nor
participated in the telecons about it. 

	Jakub

  reply	other threads:[~2015-06-09 20:24 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-29 11:44 Jakub Jelinek
2015-04-29 11:55 ` Thomas Schwinge
2015-04-29 12:31   ` Jakub Jelinek
2015-04-29 15:20     ` Thomas Schwinge
2015-06-09 18:39     ` Ilya Verbin
2015-06-09 20:25       ` Jakub Jelinek [this message]
2015-06-25 19:47         ` Ilya Verbin
2015-06-25 20:31           ` Jakub Jelinek
2015-07-17 16:47             ` Ilya Verbin
2015-07-17 16:54               ` Jakub Jelinek
2015-07-20 16:18                 ` Jakub Jelinek
2015-07-20 18:31                   ` Jakub Jelinek
2015-07-23  0:50                     ` Jakub Jelinek
2015-07-24 20:33                       ` Jakub Jelinek
2015-07-29 17:30                         ` [gomp4.1] Various accelerator updates from OpenMP 4.1 Jakub Jelinek
2015-09-04 18:17                           ` Ilya Verbin
2015-09-04 18:25                             ` Jakub Jelinek
2015-09-07 12:48                             ` Jakub Jelinek
2015-07-20 19:40                 ` [gomp4.1] Initial support for some OpenMP 4.1 construct parsing Ilya Verbin
2015-08-24 12:38                   ` Jakub Jelinek
2015-08-24 19:10                     ` Ilya Verbin
2015-06-11 12:52       ` [gomp4.1] map clause parsing improvements Jakub Jelinek
2015-10-19 10:34         ` Thomas Schwinge
2015-10-19 10:46           ` Jakub Jelinek
2015-10-19 15:14             ` Thomas Schwinge
2015-10-20 10:10               ` Jakub Jelinek
2015-10-26 13:04                 ` Ilya Verbin
2015-10-26 13:17                   ` Jakub Jelinek
2015-10-26 14:16                     ` Ilya Verbin
2016-03-17 14:34             ` Thomas Schwinge
2016-03-17 14:37               ` Jakub Jelinek
2016-03-17 14:55                 ` Jakub Jelinek
2016-03-17 15:13                 ` Rename GOMP_MAP_FORCE_DEALLOC to GOMP_MAP_DELETE (was: [gomp4.1] map clause parsing improvements) Thomas Schwinge

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150609202426.GG10247@tucnak.redhat.com \
    --to=jakub@redhat.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=iverbin@gmail.com \
    --cc=kirill.yukhin@gmail.com \
    --cc=rth@redhat.com \
    --cc=thomas@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).