public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Michael Meissner <meissner@linux.vnet.ibm.com>
To: David Edelsohn <dje.gcc@gmail.com>
Cc: Michael Meissner <meissner@linux.vnet.ibm.com>,
	       Segher Boessenkool <segher@kernel.crashing.org>,
	       GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] PR 66474, Document using %x<n> for VSX registers on PowerPC
Date: Wed, 10 Jun 2015 17:23:00 -0000	[thread overview]
Message-ID: <20150610163709.GA13213@ibm-tiger.the-meissners.org> (raw)
In-Reply-To: <CAGWvnymSsj=EO4POeHkXwtbuqimC-MddORqnmE6dLtOqSjk0rw@mail.gmail.com>

On Tue, Jun 09, 2015 at 08:28:35PM -0400, David Edelsohn wrote:
> On Tue, Jun 9, 2015 at 3:26 PM, Michael Meissner
> <meissner@linux.vnet.ibm.com> wrote:
> > On Tue, Jun 09, 2015 at 02:17:19PM -0500, Segher Boessenkool wrote:
> >> On Tue, Jun 09, 2015 at 02:00:48PM -0400, Michael Meissner wrote:
> >> > +asm ("xvadddp %x0,%x1,%x2" "=wa" (v1) : "wa" (v2), "wa" (v3));
> >>
> >> A colon went missing?       ^^^
> >
> > Yes, I will correct it when I check it in.  Thanks.
> 
> Mike,
> 
> VSX registers are a superset of Altivec registers, so the statement
> about an Altivec register used where a VSX register is expected is a
> little confusing.  How about:
> 
> Otherwise the register number output in the assembly file will be
> incorrect if an Altivec register is an operand of a VSX instruction
> that expects VSX register numbering.

The re-wording is fine with me.  I will check in the patch.  Thanks.

-- 
Michael Meissner, IBM
IBM, M/S 2506R, 550 King Street, Littleton, MA 01460-6245, USA
email: meissner@linux.vnet.ibm.com, phone: +1 (978) 899-4797

      reply	other threads:[~2015-06-10 16:37 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-09 18:29 Michael Meissner
2015-06-09 19:26 ` Segher Boessenkool
2015-06-09 19:30   ` Michael Meissner
2015-06-10  2:39     ` David Edelsohn
2015-06-10 17:23       ` Michael Meissner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150610163709.GA13213@ibm-tiger.the-meissners.org \
    --to=meissner@linux.vnet.ibm.com \
    --cc=dje.gcc@gmail.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=segher@kernel.crashing.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).