From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 83196 invoked by alias); 12 Jun 2015 08:00:45 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 83174 invoked by uid 89); 12 Jun 2015 08:00:44 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 12 Jun 2015 08:00:43 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (Postfix) with ESMTPS id 98C372D1276; Fri, 12 Jun 2015 08:00:42 +0000 (UTC) Received: from redhat.com (ovpn-204-74.brq.redhat.com [10.40.204.74]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t5C80cBX023283 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NO); Fri, 12 Jun 2015 04:00:41 -0400 Date: Fri, 12 Jun 2015 08:53:00 -0000 From: Marek Polacek To: Jan Hubicka Cc: gcc-patches@gcc.gnu.org Subject: Re: Fix verify_type ICE with -fshort-enum Message-ID: <20150612080038.GE2756@redhat.com> References: <20150611214743.GA59435@kam.mff.cuni.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150611214743.GA59435@kam.mff.cuni.cz> User-Agent: Mutt/1.5.23 (2014-03-12) X-SW-Source: 2015-06/txt/msg00904.txt.bz2 On Thu, Jun 11, 2015 at 11:47:43PM +0200, Jan Hubicka wrote: > Hi, > gcc.c-torture/execute/930408-1.c currently ICE on -fshort-enum target(s) because > TYPE_PACKED is not consistently set among type variants. I guess that's because of the forward declaration in the test. But I have no access to an ARM machine, so can't verify. > Bootstrapped/regtested ppc64le-linux, OK? > Honza > > PR middle-end/66325 > * c-decl.c (start_enum): Set TYPE_PACKED consistently among type variants. > Index: c-decl.c > =================================================================== > --- c-decl.c (revision 224250) > +++ c-decl.c (working copy) > @@ -7946,7 +7946,8 @@ > the_enum->enum_overflow = 0; > > if (flag_short_enums) > - TYPE_PACKED (enumtype) = 1; > + for (tree v = TYPE_MAIN_VARIANT (enumtype); v ;v = TYPE_NEXT_VARIANT (v)) Please fix the formatting here: no space before ;. Ok with that change. Marek