From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 71202 invoked by alias); 12 Jun 2015 07:56:44 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 71104 invoked by uid 89); 12 Jun 2015 07:56:43 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.6 required=5.0 tests=AWL,BAYES_40,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 X-Spam-User: qpsmtpd, 2 recipients X-HELO: mout.gmx.net Received: from mout.gmx.net (HELO mout.gmx.net) (212.227.15.18) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 12 Jun 2015 07:56:41 +0000 Received: from vepi2 ([88.75.104.20]) by mail.gmx.com (mrgmx001) with ESMTPSA (Nemesis) id 0MBmvH-1YvNzv2lIV-00AnbD; Fri, 12 Jun 2015 09:56:36 +0200 Date: Fri, 12 Jun 2015 08:00:00 -0000 From: Andre Vehreschild To: Thomas Koenig Cc: GCC-Patches-ML , GCC-Fortran-ML Subject: Re: [Patch, fortran, PR44672, v10] [F08] ALLOCATE with SOURCE and no array-spec Message-ID: <20150612095635.209b08d1@vepi2> In-Reply-To: <557A04D4.8050404@netcologne.de> References: <20150330194749.18e21169@vepi2> <20150401151540.4979eb07@vepi2> <20150402110330.45ad027b@vepi2> <20150423144511.5e7b12c5@gmx.de> <20150429172358.03f42041@gmx.de> <20150430161742.1273247f@gmx.de> <20150519122602.028db8d5@vepi2> <556369B1.8030600@sfr.fr> <20150528172958.456eb24d@vepi2> <55675941.2080008@sfr.fr> <20150529134603.0dc5abf9@vepi2> <556DDEDE.4000502@sfr.fr> <20150603170917.37c58865@vepi2> <20150605130401.009adf5d@vepi2> <20150610102627.1353bbd9@vepi2> <557A04D4.8050404@netcologne.de> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-UI-Out-Filterresults: notjunk:1; X-SW-Source: 2015-06/txt/msg00903.txt.bz2 Hi Thomas, thanks for the review and valuing my effort. I am on travel over the weekend, i.e., I will commit the job earliest on Monday giving objections a bit more time. Regards and thanks, Andre On Thu, 11 Jun 2015 23:59:48 +0200 Thomas Koenig wrote: > Hi Andre, > > > please find attached an updated version of the patch. This patch simplifies > > some cases and ensures more straight line code. Furthermore was a bug in the > > interfacing routine for the _vptr->_copy() routine removed, where not the > > third and fourth arguments translated to be passed be value but the fourth > > and fifth (cs start counting at zero...). > > > > Bootstraps and regtests fine on x86_64-linux-gnu/f21. > > > > Ok for trunk? > > Following the discussions, and looking through the patch, I would say > this patch is in pretty good shape (and quite impressive, too). > > My vote would be to commit as is, unless something important comes up, > and fix smaller problems and possible corner cases afterwards, if any > exist. However, I am not really deep into these aspects of the > compiler, and I would still like to leave some time for others to > comment if they think this is appropriate. > > So, OK to commit in two days unless there are objections. > > Thanks for the patch! > > Thomas > -- Andre Vehreschild * Email: vehre ad gmx dot de