From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22137 invoked by alias); 15 Jun 2015 16:25:36 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 22126 invoked by uid 89); 15 Jun 2015 16:25:35 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Mon, 15 Jun 2015 16:25:34 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (Postfix) with ESMTPS id 4D2C4293307; Mon, 15 Jun 2015 16:25:33 +0000 (UTC) Received: from tucnak.zalov.cz (ovpn-116-82.ams2.redhat.com [10.36.116.82]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t5FGPV6U019690 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Mon, 15 Jun 2015 12:25:32 -0400 Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.14.9/8.14.9) with ESMTP id t5FGPUco028416; Mon, 15 Jun 2015 18:25:30 +0200 Received: (from jakub@localhost) by tucnak.zalov.cz (8.14.9/8.14.9/Submit) id t5FGPSDp028415; Mon, 15 Jun 2015 18:25:28 +0200 Date: Mon, 15 Jun 2015 16:30:00 -0000 From: Jakub Jelinek To: Ilya Verbin Cc: Thomas Schwinge , gcc-patches@gcc.gnu.org, Kirill Yukhin Subject: Re: [gomp4.1] Add new versions of GOMP_target{,_data,_update} and GOMP_target_enter_exit_data Message-ID: <20150615162528.GU10247@tucnak.redhat.com> Reply-To: Jakub Jelinek References: <20150615122037.GA45068@msticlxl57.ims.intel.com> <20150615130609.GR10247@tucnak.redhat.com> <20150615161827.GB45068@msticlxl57.ims.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150615161827.GB45068@msticlxl57.ims.intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-IsSubscribed: yes X-SW-Source: 2015-06/txt/msg01022.txt.bz2 On Mon, Jun 15, 2015 at 07:18:27PM +0300, Ilya Verbin wrote: > On Mon, Jun 15, 2015 at 15:06:09 +0200, Jakub Jelinek wrote: > > On Mon, Jun 15, 2015 at 03:20:37PM +0300, Ilya Verbin wrote: > > > This patch introduces new versions of GOMP_target{,_data,_update} for OpenMP 4.1 > > > with unsigned short for map kinds, but without new async arguments yet. > > > > I think I'd prefer (for now) to suffix the functions with _41 instead of 1 > > (and we'll see if we can come up with better names when async support is > > added). > > OK. Thanks. > > Do we need to change GOMP_target_update though (at least right > > now)? I mean, the construct only allows to and from clauses, not the map > > clause, and those don't really have an always modifier, nor release/delete > > semantics etc., so at least for now I think using the current > > GOMP_target_update should be ok. > > I thought that it wouldn't look good, since without GOMP_target_update_41 we > will need to keep this obsolete parts: I'd prefer to keep it for now, perhaps later on we'll switch to 16-bit kinds even for that, but better figure out first what to do with the async stuff, handle the enter/exit data correctly, change the library for OpenMP 4.1 to do the fully refcounted model. Jakub