From: James Greenhalgh <james.greenhalgh@arm.com>
To: Jim Wilson <jim.wilson@linaro.org>
Cc: Kyrylo Tkachov <Kyrylo.Tkachov@arm.com>,
"gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>,
Alan Lawrence <Alan.Lawrence@arm.com>
Subject: Re: [PATCH, AARCH64] make stdarg functions work with +nofp
Date: Tue, 16 Jun 2015 08:48:00 -0000 [thread overview]
Message-ID: <20150616084626.GA31077@arm.com> (raw)
In-Reply-To: <CABXYE2Wi9y=WS9PLA23HvL7P==H_X89DOQYWWDeHRd_9jYb3+w@mail.gmail.com>
On Tue, Jun 09, 2015 at 03:18:05AM +0100, Jim Wilson wrote:
> On Tue, Jun 2, 2015 at 3:45 AM, James Greenhalgh
> <james.greenhalgh@arm.com> wrote:
> > On Tue, Jun 02, 2015 at 11:38:29AM +0100, Kyrill Tkachov wrote:
> >> Hi James, Jim,
> >>
> >> On 02/06/15 10:42, James Greenhalgh wrote:
> >> > On Sat, May 23, 2015 at 12:24:00AM +0100, Jim Wilson wrote:
> >> >> The compiler currently ICEs when compiling a stdarg function with
> >> >> +nofp, as reported in PR 66258.
>
> I'd like approval to add this patch to the gcc-5 release branch. I
> got two requests for this in the PR as currently grub won't build with
> gcc-5.1. I tested the patch on the gcc-5-release branch with a
> default languages bootstrap and make check on an APM box running
> Ubuntu. I also verified that the patch fixes my testcase.
I'm happy for this to be backported.
I think Grub probably wants to change if they want to be safe, from
what I've read it looks like they are hoping to use something like a
standard printf without touching the FP registers, which is suspect...
Thanks,
James
next prev parent reply other threads:[~2015-06-16 8:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-23 7:00 Jim Wilson
2015-06-02 9:44 ` James Greenhalgh
2015-06-02 10:45 ` Kyrill Tkachov
2015-06-02 11:03 ` James Greenhalgh
2015-06-09 5:18 ` Jim Wilson
2015-06-16 8:48 ` James Greenhalgh [this message]
2015-06-16 21:05 ` Jim Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150616084626.GA31077@arm.com \
--to=james.greenhalgh@arm.com \
--cc=Alan.Lawrence@arm.com \
--cc=Kyrylo.Tkachov@arm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jim.wilson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).