From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 107728 invoked by alias); 16 Jun 2015 08:46:33 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 107666 invoked by uid 89); 16 Jun 2015 08:46:32 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 X-HELO: cam-smtp0.cambridge.arm.com Received: from fw-tnat.cambridge.arm.com (HELO cam-smtp0.cambridge.arm.com) (217.140.96.140) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Tue, 16 Jun 2015 08:46:31 +0000 Received: from arm.com (e106375-lin.cambridge.arm.com [10.2.207.23]) by cam-smtp0.cambridge.arm.com (8.13.8/8.13.8) with ESMTP id t5G8kQ3O023412; Tue, 16 Jun 2015 09:46:26 +0100 Date: Tue, 16 Jun 2015 08:48:00 -0000 From: James Greenhalgh To: Jim Wilson Cc: Kyrylo Tkachov , "gcc-patches@gcc.gnu.org" , Alan Lawrence Subject: Re: [PATCH, AARCH64] make stdarg functions work with +nofp Message-ID: <20150616084626.GA31077@arm.com> References: <20150602094230.GA4502@arm.com> <556D87A5.8020808@arm.com> <20150602104509.GA30419@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes X-SW-Source: 2015-06/txt/msg01071.txt.bz2 On Tue, Jun 09, 2015 at 03:18:05AM +0100, Jim Wilson wrote: > On Tue, Jun 2, 2015 at 3:45 AM, James Greenhalgh > wrote: > > On Tue, Jun 02, 2015 at 11:38:29AM +0100, Kyrill Tkachov wrote: > >> Hi James, Jim, > >> > >> On 02/06/15 10:42, James Greenhalgh wrote: > >> > On Sat, May 23, 2015 at 12:24:00AM +0100, Jim Wilson wrote: > >> >> The compiler currently ICEs when compiling a stdarg function with > >> >> +nofp, as reported in PR 66258. > > I'd like approval to add this patch to the gcc-5 release branch. I > got two requests for this in the PR as currently grub won't build with > gcc-5.1. I tested the patch on the gcc-5-release branch with a > default languages bootstrap and make check on an APM box running > Ubuntu. I also verified that the patch fixes my testcase. I'm happy for this to be backported. I think Grub probably wants to change if they want to be safe, from what I've read it looks like they are hoping to use something like a standard printf without touching the FP registers, which is suspect... Thanks, James