From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 73337 invoked by alias); 17 Jun 2015 16:10:06 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 73323 invoked by uid 89); 17 Jun 2015 16:10:05 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 X-HELO: cam-smtp0.cambridge.arm.com Received: from fw-tnat.cambridge.arm.com (HELO cam-smtp0.cambridge.arm.com) (217.140.96.140) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Wed, 17 Jun 2015 16:10:04 +0000 Received: from arm.com (e106375-lin.cambridge.arm.com [10.2.207.23]) by cam-smtp0.cambridge.arm.com (8.13.8/8.13.8) with ESMTP id t5HGA0VO022724; Wed, 17 Jun 2015 17:10:00 +0100 Date: Wed, 17 Jun 2015 16:35:00 -0000 From: James Greenhalgh To: Marcus Shawcroft Cc: Kugan , "gcc-patches@gcc.gnu.org" Subject: Re: [RFC][AARCH64] TARGET_ATOMIC_ASSIGN_EXPAND_FENV hook Message-ID: <20150617161000.GA3016@arm.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes X-SW-Source: 2015-06/txt/msg01213.txt.bz2 On Thu, May 22, 2014 at 03:24:23PM +0100, Marcus Shawcroft wrote: > On 2 May 2014 13:27, Kugan wrote: > > > +2014-05-02 Kugan Vivekanandarajah > > + > > + * config/aarch64/aarch64.c (TARGET_ATOMIC_ASSIGN_EXPAND_FENV): New > > + define. > > + * config/aarch64/aarch64-protos.h (aarch64_atomic_assign_expand_fenv): > > + New function declaration. > > + * config/aarch64/aarch64-builtins.c (aarch64_builtins) : Add > > + AARCH64_BUILTIN_GET_FPCR, AARCH64_BUILTIN_SET_FPCR. > > + AARCH64_BUILTIN_GET_FPSR and AARCH64_BUILTIN_SET_FPSR. > > + (aarch64_init_builtins) : Initialize builtins > > + __builtins_aarch64_set_fpcr, __builtins_aarch64_get_fpcr. > > + __builtins_aarch64_set_fpsr and __builtins_aarch64_get_fpsr. > > + (aarch64_expand_builtin) : Expand builtins __builtins_aarch64_set_fpcr > > + __builtins_aarch64_get_fpcr, __builtins_aarch64_get_fpsr, > > + and __builtins_aarch64_set_fpsr. > > + (aarch64_atomic_assign_expand_fenv): New function. > > + * config/aarch64/aarch64.md (set_fpcr): New pattern. > > + (get_fpcr) : Likewise. > > + (set_fpsr) : Likewise. > > + (get_fpsr) : Likewise. > > + (unspecv): Add UNSPECV_GET_FPCR and UNSPECV_SET_FPCR, UNSPECV_GET_FPSR > > + and UNSPECV_SET_FPSR. > > + * doc/extend.texi (AARCH64 Built-in Functions) : Document > > + __builtins_aarch64_set_fpcr, __builtins_aarch64_get_fpcr. > > + __builtins_aarch64_set_fpsr and __builtins_aarch64_get_fpsr. > > + > > OK, thanks Kugan. > I appreciate it is quite late in the day for the 4.9.3 branch, but do we want to consider this patch for backporting (either now or after the branch reopens)? gcc.dg/atomic/c11-atomic-exec-5.c is the only interesting test I see failing on a native AArch64 build of the 4.9.3 release candidate (there is plenty of other FAILures, but they are guality, scan assembler or missed optimization fails). Thanks, James