From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 107930 invoked by alias); 23 Jun 2015 12:34:57 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 107816 invoked by uid 89); 23 Jun 2015 12:34:57 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.1 required=5.0 tests=AWL,BAYES_40,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 23 Jun 2015 12:34:55 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (Postfix) with ESMTPS id AE9813679E8; Tue, 23 Jun 2015 12:34:53 +0000 (UTC) Received: from tucnak.zalov.cz (ovpn-116-82.ams2.redhat.com [10.36.116.82]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t5NCYpi1008780 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Tue, 23 Jun 2015 08:34:53 -0400 Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.14.9/8.14.9) with ESMTP id t5NCYoei005173; Tue, 23 Jun 2015 14:34:50 +0200 Received: (from jakub@localhost) by tucnak.zalov.cz (8.14.9/8.14.9/Submit) id t5NCYmGS005172; Tue, 23 Jun 2015 14:34:48 +0200 Date: Tue, 23 Jun 2015 12:38:00 -0000 From: Jakub Jelinek To: Daniel Cederman Cc: gcc-patches@gcc.gnu.org, daniel@gaisler.com, ebotcazou@adacore.com Subject: Re: [PATCH] Make muser-mode the default for LEON3 Message-ID: <20150623123448.GP10247@tucnak.redhat.com> Reply-To: Jakub Jelinek References: <1435062156-28097-1-git-send-email-cederman@gaisler.com> <1435062156-28097-2-git-send-email-cederman@gaisler.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1435062156-28097-2-git-send-email-cederman@gaisler.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-IsSubscribed: yes X-SW-Source: 2015-06/txt/msg01543.txt.bz2 On Tue, Jun 23, 2015 at 02:22:34PM +0200, Daniel Cederman wrote: > The muser-mode flag causes the CASA instruction for LEON3 to use the > user mode ASI. This is the correct behavior for almost all LEON3 targets. > For this reason it makes sense to make user mode the default. This patch > adds a flag for supervisor mode that can be used on the very few LEON3 targets > that requires CASA to use the supervisor ASI. Why are you adding a new option and without deprecation removing a previously accepted (at least since 4.8) option? For just changing the default, you really don't need to add a new option or remove -mno-user-mode, just change the default, which can be done e.g. by checking if the bit has been explicitly set and if not, use the desired default, or if you want to change the Mask() name, just make it InverseMask, but keep the options as they are. Jakub