From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 59056 invoked by alias); 26 Jun 2015 10:15:16 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 59045 invoked by uid 89); 26 Jun 2015 10:15:15 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 X-HELO: cam-smtp0.cambridge.arm.com Received: from fw-tnat.cambridge.arm.com (HELO cam-smtp0.cambridge.arm.com) (217.140.96.140) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Fri, 26 Jun 2015 10:15:13 +0000 Received: from arm.com (e106375-lin.cambridge.arm.com [10.2.207.23]) by cam-smtp0.cambridge.arm.com (8.13.8/8.13.8) with ESMTP id t5QAF6v7024424; Fri, 26 Jun 2015 11:15:06 +0100 Date: Fri, 26 Jun 2015 10:17:00 -0000 From: James Greenhalgh To: Richard Earnshaw Cc: "Thomas Preud'homme" , "gcc-patches@gcc.gnu.org" , Ramana Radhakrishnan , Kyrylo Tkachov Subject: Re: [PATCH, ARM] Restrict pr65647 testcase to ARMv6-M effective target Message-ID: <20150626101505.GA29643@arm.com> References: <003001d0afec$6de65a60$49b30f20$@arm.com> <558D1259.8090803@foss.arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <558D1259.8090803@foss.arm.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes X-SW-Source: 2015-06/txt/msg01924.txt.bz2 On Fri, Jun 26, 2015 at 09:50:33AM +0100, Richard Earnshaw wrote: > On 26/06/15 09:45, Thomas Preud'homme wrote: > > Hi, > > > > Testcase for PR65647 assumes that the compiler can compile for ARMv6-M > > which might not be the case if passing some extra options via > > RUNTESTFLAGS (eg. -marm/-mcpu=cortex-a9). This patch restricts the > > testcase to ARMv6-M effective targets. > > > > > > Testsuite ChangeLog entry is as follows: > > > > 2015-06-25 Thomas Preud'homme > > > > * gcc.target/arm/pr65647.c: Restrict to ARMv6-M effective targets. > > > > > > diff --git a/gcc/testsuite/gcc.target/arm/pr65647.c b/gcc/testsuite/gcc.target/arm/pr65647.c > > index d3b44b2..d828d23 100644 > > --- a/gcc/testsuite/gcc.target/arm/pr65647.c > > +++ b/gcc/testsuite/gcc.target/arm/pr65647.c > > @@ -1,4 +1,5 @@ > > /* { dg-do compile } */ > > +/* { dg-require-effective-target arm_arch_v6m_ok } */ > > /* { dg-options "-march=armv6-m -mthumb -O3 -w -mfloat-abi=soft" } */ > > > > a, b, c, e, g = &e, h, i = 7, l = 1, m, n, o, q = &m, r, s = &r, u, w = 9, x, > > > > > > Patch was tested by running the testcase once with -mcpu=cortex-a9 > > (skipped as expected) and once with -mcpu=cortex-m0 (passes). > > > > Is this ok for trunk? > > > > OK. This should already have been covered by: https://gcc.gnu.org/ml/gcc-patches/2015-06/msg01105.html 2015-06-16 James Greenhalgh * gcc.target/arm/pr65647.c: Do not override -mfloat-abi directives passed by the testsuite driver. Thanks, James --- diff --git a/gcc/testsuite/gcc.target/arm/pr65647.c b/gcc/testsuite/gcc.target/arm/pr65647.c index d3b44b2..26b4e39 100644 --- a/gcc/testsuite/gcc.target/arm/pr65647.c +++ b/gcc/testsuite/gcc.target/arm/pr65647.c @@ -1,4 +1,6 @@ /* { dg-do compile } */ +/* { dg-require-effective-target arm_arch_v6m_ok } */ +/* { dg-skip-if "do not override -mfloat-abi" { *-*-* } { "-mfloat-abi=*" } {"-mfloat-abi=soft" } } */ /* { dg-options "-march=armv6-m -mthumb -O3 -w -mfloat-abi=soft" } */ a, b, c, e, g = &e, h, i = 7, l = 1, m, n, o, q = &m, r, s = &r, u, w = 9, x, > > Best regards, > > > > Thomas > > > > >