From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 38360 invoked by alias); 7 Jul 2015 09:54:15 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 38348 invoked by uid 89); 7 Jul 2015 09:54:15 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 07 Jul 2015 09:54:14 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (Postfix) with ESMTPS id D829BCDF; Tue, 7 Jul 2015 09:54:12 +0000 (UTC) Received: from tucnak.zalov.cz (ovpn-116-82.ams2.redhat.com [10.36.116.82]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t679sBKq002108 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Tue, 7 Jul 2015 05:54:12 -0400 Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.14.9/8.14.9) with ESMTP id t679s9Xk021693; Tue, 7 Jul 2015 11:54:10 +0200 Received: (from jakub@localhost) by tucnak.zalov.cz (8.14.9/8.14.9/Submit) id t679s8eR021692; Tue, 7 Jul 2015 11:54:08 +0200 Date: Tue, 07 Jul 2015 09:54:00 -0000 From: Jakub Jelinek To: Nathan Sidwell Cc: GCC Patches Subject: Re: [gomp] Move openacc vector& worker single handling to RTL Message-ID: <20150707095408.GD10247@tucnak.redhat.com> Reply-To: Jakub Jelinek References: <5597120D.2080308@acm.org> <20150703231159.GP10247@tucnak.redhat.com> <559844EF.6010208@acm.org> <559AD85B.2050102@acm.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <559AD85B.2050102@acm.org> User-Agent: Mutt/1.5.23 (2014-03-12) X-IsSubscribed: yes X-SW-Source: 2015-07/txt/msg00456.txt.bz2 On Mon, Jul 06, 2015 at 03:34:51PM -0400, Nathan Sidwell wrote: > On 07/04/15 16:41, Nathan Sidwell wrote: > >On 07/03/15 19:11, Jakub Jelinek wrote: > > >>If the builtins are not meant to be used by users directly (I assume they > >>aren't) nor have a 1-1 correspondence to a library routine, it is much > >>better to emit them as internal calls (see internal-fn.{c,def}) instead of > >>BUILT_IN_NORMAL functions. > > > > This patch uses internal builtins, I had to make one additional change to > tree-ssa-tail-merge.c's same_succ_def::equal hash compare function. The new > internal fn I introduced should compare EQ but not otherwise compare EQUAL, > and that was blowing up the has function, which relied on EQUAL only. I > don't know why I didn't hit this problem in the previous patch with the > regular builtin. How does this interact with #pragma acc routine {gang,worker,vector,seq} ? Or is that something to be added later on? Jakub