From: Jakub Jelinek <jakub@redhat.com>
To: Maxim Blumental <bvmaks@gmail.com>
Cc: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Subject: Re: Tests for libgomp based on OpenMP Examples 4.0.2.
Date: Tue, 07 Jul 2015 18:17:00 -0000 [thread overview]
Message-ID: <20150707181748.GN10247@tucnak.redhat.com> (raw)
In-Reply-To: <CACy_Q+yNNb4sBv6rvBawFNUt5LwbaOgjHHdRarfkhNqBULi1sw@mail.gmail.com>
On Tue, Jul 07, 2015 at 08:08:16PM +0300, Maxim Blumental wrote:
> Comment on the patch:
>
> simd-5.f90 file is marked as xfail since the test fails because 'simd
> collapse' is an unsupported combination for Fortran (which though is
> valid in OpenMP API).
I'll have a look, that is supposed to work.
> 2015-07-07 19:48 GMT+03:00 Maxim Blumental <bvmaks@gmail.com>:
> > With this letter I propose a patch with tests for libgomp based on
> > OpenMP Examples 4.0.2 both for C and Fortran.
> >
> > The changes are:
> >
> > Renamed existing tests based on OpenMP Examples to make the names more clear.
If anything, the test could be renamed to match
https://github.com/OpenMP/Examples/tree/master/sources/
filenames, but certainly not to made up names. The Examples-4/
directory is supposed to only contain the tests from the 4.0.* examples
document and no other tests.
> > Added 16 tests for simd construct and 10 for depend clause.
Any new tests that aren't in Examples 4.0.* document should go one level
higher, to libgomp.{c,c++,fortran}/ directly.
Jakub
next prev parent reply other threads:[~2015-07-07 18:17 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-07 16:48 Maxim Blumental
2015-07-07 17:08 ` Maxim Blumental
2015-07-07 18:17 ` Jakub Jelinek [this message]
2015-07-07 18:30 ` Ilya Verbin
2015-07-08 12:51 ` Maxim Blumental
2015-07-08 13:00 ` Maxim Blumental
2015-07-09 12:57 ` Maxim Blumental
2015-07-09 14:23 ` Maxim Blumental
2015-07-09 20:14 ` Jakub Jelinek
2015-07-14 13:41 ` Jakub Jelinek
[not found] ` <CACy_Q+xw79aVfMxHg00LX7OWRqLUKS4LE4QtV=RSqMSS8vV=Vw@mail.gmail.com>
[not found] ` <20150714172935.GM1788@tucnak.redhat.com>
[not found] ` <CACy_Q+x4JiHm_=BaSDmxCXqFJmChh=vvTv+22Xh-9x2br1HUAQ@mail.gmail.com>
2015-07-14 17:46 ` Maxim Blumental
2015-07-14 18:28 ` Jakub Jelinek
2015-07-20 19:58 ` H.J. Lu
2015-07-22 13:57 ` Maxim Blumental
2015-07-22 14:16 ` Jakub Jelinek
2015-07-22 15:12 ` Maxim Blumental
2015-07-22 15:30 ` Jakub Jelinek
2015-07-15 10:49 Dominique d'Humières
2015-07-15 13:37 ` Ilya Verbin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150707181748.GN10247@tucnak.redhat.com \
--to=jakub@redhat.com \
--cc=bvmaks@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).