From: Jakub Jelinek <jakub@redhat.com>
To: Richard Biener <rguenther@suse.de>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] Fix PR66805 - #pragma pack affecting gcov_info_type layout
Date: Wed, 08 Jul 2015 12:42:00 -0000 [thread overview]
Message-ID: <20150708124249.GZ10247@tucnak.redhat.com> (raw)
In-Reply-To: <alpine.LSU.2.11.1507081440010.9923@zhemvz.fhfr.qr>
On Wed, Jul 08, 2015 at 02:40:33PM +0200, Richard Biener wrote:
> > toplev.c already sets maximum_field_alignment directly, and to a different
> > value:
> > maximum_field_alignment = initial_max_fld_align * BITS_PER_UNIT;
> > so I'm not sure you need a new function. And, shouldn't you reset to
> > maximum_field_alignment = initial_max_fld_align * BITS_PER_UNIT;
> > ? -fpack-struct= is an ABI changing option, so IMHO it should affect
> > even gcov_info_type etc.
>
> That would support the 2nd patch variant. Note that -fpack-struct
> can be specified in optimize attributes...
Yeah, the second patch LGTM.
Jakub
next prev parent reply other threads:[~2015-07-08 12:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-08 11:58 Richard Biener
2015-07-08 12:08 ` Richard Biener
2015-07-08 12:10 ` Jakub Jelinek
2015-07-08 12:40 ` Richard Biener
2015-07-08 12:42 ` Jakub Jelinek [this message]
2015-07-08 12:36 ` Alexander Monakov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150708124249.GZ10247@tucnak.redhat.com \
--to=jakub@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=rguenther@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).