From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5635 invoked by alias); 9 Jul 2015 06:44:18 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 5626 invoked by uid 89); 9 Jul 2015 06:44:17 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD autolearn=no version=3.3.2 X-HELO: e06smtp11.uk.ibm.com Received: from e06smtp11.uk.ibm.com (HELO e06smtp11.uk.ibm.com) (195.75.94.107) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (CAMELLIA256-SHA encrypted) ESMTPS; Thu, 09 Jul 2015 06:44:16 +0000 Received: from /spool/local by e06smtp11.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 9 Jul 2015 07:44:13 +0100 Received: from d06dlp01.portsmouth.uk.ibm.com (9.149.20.13) by e06smtp11.uk.ibm.com (192.168.101.141) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Thu, 9 Jul 2015 07:44:11 +0100 X-MailFrom: vogt@linux.vnet.ibm.com X-RcptTo: gcc-patches@gcc.gnu.org Received: from b06cxnps3074.portsmouth.uk.ibm.com (d06relay09.portsmouth.uk.ibm.com [9.149.109.194]) by d06dlp01.portsmouth.uk.ibm.com (Postfix) with ESMTP id 3471617D8059 for ; Thu, 9 Jul 2015 07:45:27 +0100 (BST) Received: from d06av06.portsmouth.uk.ibm.com (d06av06.portsmouth.uk.ibm.com [9.149.37.217]) by b06cxnps3074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id t696iAII35586094 for ; Thu, 9 Jul 2015 06:44:10 GMT Received: from d06av06.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av06.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id t691b5aP007206 for ; Wed, 8 Jul 2015 21:37:05 -0400 Received: from bl3ahm9f.de.ibm.com (dyn-9-152-212-207.boeblingen.de.ibm.com [9.152.212.207]) by d06av06.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with ESMTP id t691b5WS007198; Wed, 8 Jul 2015 21:37:05 -0400 Received: from dvogt by bl3ahm9f.de.ibm.com with local (Exim 4.76) (envelope-from ) id 1ZD5Z3-00021w-KZ; Thu, 09 Jul 2015 08:44:09 +0200 Date: Thu, 09 Jul 2015 06:44:00 -0000 From: Dominik Vogt To: gcc-patches@gcc.gnu.org Cc: krebbel@linux.vnet.ibm.com, DJ Delorie Subject: Re: [PATCH] S390: Support -mtune=native and -march=native. Message-ID: <20150709064409.GA7485@linux.vnet.ibm.com> Reply-To: vogt@linux.vnet.ibm.com Mail-Followup-To: gcc-patches@gcc.gnu.org, krebbel@linux.vnet.ibm.com, DJ Delorie References: <20150519060513.GA3754@linux.vnet.ibm.com> <20150526110651.GA6116@linux.vnet.ibm.com> <201507082018.t68KIlYE028311@greed.delorie.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="FL5UXtIhxfXey3p5" Content-Disposition: inline In-Reply-To: <201507082018.t68KIlYE028311@greed.delorie.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 15070906-0041-0000-0000-000005071E57 X-SW-Source: 2015-07/txt/msg00678.txt.bz2 --FL5UXtIhxfXey3p5 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-length: 654 On Wed, Jul 08, 2015 at 04:18:47PM -0400, DJ Delorie wrote: > > > Version 2 of the patch to enable the configure options > > --with-arch=native and --with-tune=native. > > This patch broke cross-compiling with --target=s390-* > > s390_host_detect_local_cpu is only defined if the --host is s390-* > > but EXTRA_SPEC_FUNCTIONS refers to it when --target is s390-* Sorry about that. Does the attached Patch fix the problem? gcc/ChangeLog: -------------- 2015-07-09 Dominik Vogt * config/s390/s390.h: S390: Do not define EXTRA_SPEC_FUNCTIONS when cross compiling. Ciao Dominik ^_^ ^_^ -- Dominik Vogt IBM Germany --FL5UXtIhxfXey3p5 Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="0001-S390-Do-not-define-EXTRA_SPEC_FUNCTIONS-when-cross-c.patch" Content-length: 1709 >From 86e02035d8011fa158125a541cde5cc55a21c1ea Mon Sep 17 00:00:00 2001 From: Dominik Vogt Date: Thu, 9 Jul 2015 07:31:42 +0100 Subject: [PATCH] S390: Do not define EXTRA_SPEC_FUNCTIONS when cross compiling. --- gcc/config/s390/s390.h | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/gcc/config/s390/s390.h b/gcc/config/s390/s390.h index 85a0d1a..362e3d4 100644 --- a/gcc/config/s390/s390.h +++ b/gcc/config/s390/s390.h @@ -126,26 +126,30 @@ enum processor_flags { "arch", "%{!march=*:-march=%(VALUE)}" }, \ { "tune", "%{!mtune=*:-mtune=%(VALUE)}" } +#ifdef __s390__ extern const char *s390_host_detect_local_cpu (int argc, const char **argv); # define EXTRA_SPEC_FUNCTIONS \ { "local_cpu_detect", s390_host_detect_local_cpu }, # define MARCH_MTUNE_NATIVE_SPECS \ - " %{march=native:%