From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 56371 invoked by alias); 13 Jul 2015 13:49:38 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 56360 invoked by uid 89); 13 Jul 2015 13:49:37 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-wi0-f173.google.com Received: from mail-wi0-f173.google.com (HELO mail-wi0-f173.google.com) (209.85.212.173) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Mon, 13 Jul 2015 13:49:36 +0000 Received: by widjy10 with SMTP id jy10so70166368wid.1 for ; Mon, 13 Jul 2015 06:49:33 -0700 (PDT) X-Received: by 10.180.14.101 with SMTP id o5mr5621078wic.82.1436795373320; Mon, 13 Jul 2015 06:49:33 -0700 (PDT) Received: from msticlxl57.ims.intel.com (fmdmzpr01-ext.fm.intel.com. [192.55.54.36]) by smtp.gmail.com with ESMTPSA id ho10sm29320497wjb.39.2015.07.13.06.49.30 (version=TLSv1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 13 Jul 2015 06:49:32 -0700 (PDT) Date: Mon, 13 Jul 2015 13:49:00 -0000 From: Ilya Verbin To: Nathan Sidwell Cc: GCC Patches Subject: Re: GOMP_offload_register Message-ID: <20150713134924.GB56059@msticlxl57.ims.intel.com> References: <55A3C05A.5010101@acm.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <55A3C05A.5010101@acm.org> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes X-SW-Source: 2015-07/txt/msg01042.txt.bz2 On Mon, Jul 13, 2015 at 09:42:50 -0400, Nathan Sidwell wrote: > GOMP_offload_register's target data argument is 'void *'. Is there > any reason it shouldn't be 'const void *'? It would seem to me that > that would be better? > > (a cursory look at i386/intelmic-mkoffload.c suggests a lack of > consts in the variable decls there. ptx suffers the same problem) I can't remember any reason, so I agree that const is better (if this works :) -- Ilya