From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 78238 invoked by alias); 14 Jul 2015 11:41:22 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 78229 invoked by uid 89); 14 Jul 2015 11:41:21 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-qg0-f45.google.com Received: from mail-qg0-f45.google.com (HELO mail-qg0-f45.google.com) (209.85.192.45) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Tue, 14 Jul 2015 11:41:20 +0000 Received: by qgy5 with SMTP id 5so2673511qgy.3 for ; Tue, 14 Jul 2015 04:41:18 -0700 (PDT) X-Received: by 10.140.109.119 with SMTP id k110mr59772567qgf.53.1436874078335; Tue, 14 Jul 2015 04:41:18 -0700 (PDT) Received: from msticlxl57.ims.intel.com ([192.55.54.40]) by smtp.gmail.com with ESMTPSA id l33sm318039qkh.12.2015.07.14.04.41.14 (version=TLSv1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 14 Jul 2015 04:41:17 -0700 (PDT) Date: Tue, 14 Jul 2015 11:41:00 -0000 From: Ilya Verbin To: Jakub Jelinek Cc: gcc-patches@gcc.gnu.org Subject: Re: [gomp4.1] Handle linear clause modifiers in declare simd Message-ID: <20150714114034.GA901@msticlxl57.ims.intel.com> References: <20150701105538.GT10247@tucnak.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20150701105538.GT10247@tucnak.redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes X-SW-Source: 2015-07/txt/msg01141.txt.bz2 On Wed, Jul 01, 2015 at 12:55:38 +0200, Jakub Jelinek wrote: > * cgraph.h (enum cgraph_simd_clone_arg_type): Add > SIMD_CLONE_ARG_TYPE_LINEAR_REF_CONSTANT_STEP, > SIMD_CLONE_ARG_TYPE_LINEAR_UVAL_CONSTANT_STEP, > and SIMD_CLONE_ARG_TYPE_LINEAR_VAL_CONSTANT_STEP. > (struct cgraph_simd_clone_arg): Adjust comment. > * omp-low.c (simd_clone_clauses_extract): Honor > OMP_CLAUSE_LINEAR_KIND. > (simd_clone_mangle): Mangle the various linear kinds > per the new ABI. > (simd_clone_adjust_argument_types): Handle > SIMD_CLONE_ARG_TYPE_LINEAR_*_CONSTANT_STEP. > (simd_clone_init_simd_arrays): Don't do anything > for uval. > (simd_clone_adjust): Handle > SIMD_CLONE_ARG_TYPE_LINEAR_REF_CONSTANT_STEP like > SIMD_CLONE_ARG_TYPE_LINEAR_CONSTANT_STEP. > Handle SIMD_CLONE_ARG_TYPE_LINEAR_UVAL_CONSTANT_STEP. > c/ > * c-tree.h (c_finish_omp_clauses): Add declare_simd argument. > * c-parser.c (c_parser_omp_clause_linear): Don't handle uval > modifier in C. > (c_parser_omp_all_clauses): If mask includes uniform clause, > pass true to c_finish_omp_clauses' declare_simd. > * c-typeck.c (c_finish_omp_clauses): Add declare_simd argument, > don't set need_implicitly_determined if it is true. > cp/ > * cp-tree.h (finish_omp_clauses): Add declare_simd argument. > * parser.c (cp_parser_omp_all_clauses): If mask includes uniform > clause, pass true to finish_omp_clauses' declare_simd. > * pt.c (apply_late_template_attributes): Pass true to > finish_omp_clauses' declare_simd. > * semantics.c (finish_omp_clauses): Add declare_simd argument, > don't set need_implicitly_determined if it is true. > testsuite/ > * gcc.dg/gomp/clause-1.c (foo): Add some linear clause tests. > * g++.dg/gomp/clause-3.C (foo): Likewise. > * g++.dg/gomp/declare-simd-3.C: New test. This caused: gcc/tree-vect-stmts.c: In function ‘bool vectorizable_simd_clone_call(gimple, gimple_stmt_iterator*, gimple_statement_base**, slp_tree)’: gcc/tree-vect-stmts.c:2810:13: error: enumeration value ‘SIMD_CLONE_ARG_TYPE_LINEAR_REF_CONSTANT_STEP’ not handled in switch [-Werror=switch] switch (n->simdclone->args[i].arg_type) ^ gcc/tree-vect-stmts.c:2810:13: error: enumeration value ‘SIMD_CLONE_ARG_TYPE_LINEAR_UVAL_CONSTANT_STEP’ not handled in switch [-Werror=switch] gcc/tree-vect-stmts.c:2810:13: error: enumeration value ‘SIMD_CLONE_ARG_TYPE_LINEAR_VAL_CONSTANT_STEP’ not handled in switch [-Werror=switch] cc1plus: all warnings being treated as errors make[4]: *** [tree-vect-stmts.o] Error 1 -- Ilya