From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7101 invoked by alias); 14 Jul 2015 12:48:55 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 7088 invoked by uid 89); 14 Jul 2015 12:48:54 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 14 Jul 2015 12:48:53 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (Postfix) with ESMTPS id 86192BBB5A; Tue, 14 Jul 2015 12:48:52 +0000 (UTC) Received: from tucnak.zalov.cz (ovpn-116-44.ams2.redhat.com [10.36.116.44]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t6ECmoeS024230 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Tue, 14 Jul 2015 08:48:52 -0400 Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.14.9/8.14.9) with ESMTP id t6ECmmUO004305; Tue, 14 Jul 2015 14:48:49 +0200 Received: (from jakub@localhost) by tucnak.zalov.cz (8.14.9/8.14.9/Submit) id t6ECmlFF004304; Tue, 14 Jul 2015 14:48:47 +0200 Date: Tue, 14 Jul 2015 12:48:00 -0000 From: Jakub Jelinek To: Ilya Verbin Cc: gcc-patches@gcc.gnu.org Subject: Re: [gomp4.1] Handle linear clause modifiers in declare simd Message-ID: <20150714124847.GF1788@tucnak.redhat.com> Reply-To: Jakub Jelinek References: <20150701105538.GT10247@tucnak.redhat.com> <20150714114034.GA901@msticlxl57.ims.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20150714114034.GA901@msticlxl57.ims.intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-IsSubscribed: yes X-SW-Source: 2015-07/txt/msg01148.txt.bz2 On Tue, Jul 14, 2015 at 02:41:04PM +0300, Ilya Verbin wrote: > This caused: > > gcc/tree-vect-stmts.c: In function ‘bool vectorizable_simd_clone_call(gimple, gimple_stmt_iterator*, gimple_statement_base**, slp_tree)’: > gcc/tree-vect-stmts.c:2810:13: error: enumeration value ‘SIMD_CLONE_ARG_TYPE_LINEAR_REF_CONSTANT_STEP’ not handled in switch [-Werror=switch] > switch (n->simdclone->args[i].arg_type) > ^ > gcc/tree-vect-stmts.c:2810:13: error: enumeration value ‘SIMD_CLONE_ARG_TYPE_LINEAR_UVAL_CONSTANT_STEP’ not handled in switch [-Werror=switch] > gcc/tree-vect-stmts.c:2810:13: error: enumeration value ‘SIMD_CLONE_ARG_TYPE_LINEAR_VAL_CONSTANT_STEP’ not handled in switch [-Werror=switch] > cc1plus: all warnings being treated as errors > make[4]: *** [tree-vect-stmts.o] Error 1 Oops, missed that warning (and haven't bootstrapped the branch for a while now). Fixed thusly, to handle VAL/UVAL better we'll need to find the last store into the memory and determine if the stored value is linear. Something deferred for later. 2015-07-14 Jakub Jelinek * tree-vect-stmts.c (vectorizable_simd_clone_call): Handle SIMD_CLONE_ARG_TYPE_LINEAR_{REF,VAL,UVAL}_CONSTANT_STEP. --- gcc/tree-vect-stmts.c.jj 2015-07-14 14:30:06.000000000 +0200 +++ gcc/tree-vect-stmts.c 2015-07-14 14:45:08.032376586 +0200 @@ -2825,6 +2825,7 @@ vectorizable_simd_clone_call (gimple stm i = -1; break; case SIMD_CLONE_ARG_TYPE_LINEAR_CONSTANT_STEP: + case SIMD_CLONE_ARG_TYPE_LINEAR_REF_CONSTANT_STEP: if (arginfo[i].dt == vect_constant_def || arginfo[i].dt == vect_external_def || (arginfo[i].linear_step @@ -2832,6 +2833,8 @@ vectorizable_simd_clone_call (gimple stm i = -1; break; case SIMD_CLONE_ARG_TYPE_LINEAR_VARIABLE_STEP: + case SIMD_CLONE_ARG_TYPE_LINEAR_VAL_CONSTANT_STEP: + case SIMD_CLONE_ARG_TYPE_LINEAR_UVAL_CONSTANT_STEP: /* FORNOW */ i = -1; break; Jakub